Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce numbering system allow list to officially supported ones #8216

Closed
1 of 4 tasks
jcfranco opened this issue Nov 18, 2023 · 8 comments
Closed
1 of 4 tasks

Reduce numbering system allow list to officially supported ones #8216

jcfranco opened this issue Nov 18, 2023 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. docs Issues relating to documentation updates only. estimate - 2 Small fix or update, may require updates to tests. i18n-l10n issues dealing with internationalization/localization p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 November Pri...

Comments

@jcfranco
Copy link
Member

jcfranco commented Nov 18, 2023 •
edited by geospatialem
Loading

Description

We are officially supporting arab, arabext, and latn as numbering systems, so we need to make this clear in the code and documentation.

cc @annierm18 @eriklharper

Proposed Advantages

Clearer story regarding supported numbering systems.

Which Component

This would impact all components supporting a numberingSystem prop.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. p - high Issue should be addressed in the current milestone, impacts component or core functionality 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. labels Nov 18, 2023
@jcfranco jcfranco added this to the 2023 November Priorities milestone Nov 18, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. labels Nov 18, 2023
@jcfranco jcfranco mentioned this issue Nov 18, 2023
Merged
@jcfranco
Copy link
Member Author

+@macandcheese @geospatialem for doc and doc-site considerations.

@benelan
Copy link
Member

benelan commented Nov 18, 2023

+@macandcheese @geospatialem for doc and doc-site considerations.

++ @DitwanP

Can we add the new list of supported numbering systems to this section, since we already list the langs above it?

We should probably also remove the part saying to check MDN for a list of available numbering systems. But I think we should still link to MDN for the "more info".

The list of numbering systems in the prop doc will automatically be updated since it comes from the source code.

Thanks!

@jcfranco jcfranco added the i18n-l10n issues dealing with internationalization/localization label Nov 18, 2023
@geospatialem geospatialem added the docs Issues relating to documentation updates only. label Nov 20, 2023
@geospatialem
Copy link
Member

Added the docs label per updating the Localization page's numbering system section to include the supporting list.

@eriklharper
Copy link
Contributor

A numbering system conveys numbers using digits or symbols in a consistent format, as defined by the set lang.

I think we should revise this sentence in the docs as well. Technically the lang doesn't define the numbering-system since its a separate property and we're not forcing ar to use the arab numbering-system, for example.

@eriklharper
Copy link
Contributor

It would be cool to add arab and arabext as supported numbering systems next to or maybe as a sub-bullet below the applicable lang/locale, so in this case Arabic (ar). I think we should go so far as to say "only specific combinations of lang and numbering-system are supported, and here's what they are". Same goes for thethai numbering system with the Thai (th) locale.

benelan added a commit that referenced this issue Nov 22, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
ab1a62a 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 22, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco and benelan Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

benelan added a commit that referenced this issue Nov 23, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
a74b834 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
benelan added a commit that referenced this issue Nov 29, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
a512045 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
@geospatialem
Copy link
Member

The documentation update has been installed today, 11/30, and will be part of tomorrow's documentation release on production, 12/1.

@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Dec 1, 2023
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Dec 1, 2023
@geospatialem
Copy link
Member

Verified on the rc branch and on today's documentation site release.

benelan added a commit that referenced this issue Dec 1, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
6efe255 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
benelan added a commit that referenced this issue Dec 1, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
1cac795 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
benelan added a commit that referenced this issue Dec 2, 2023
@benelan @jcfranco
refactor(i18n)!: reduce list of supported numbering systems (#8217)
9946ac1 
**Related Issue:** #8216

## Summary

Reduce the list of supported numbering systems to `arab`, `arabext`, and
`latn` after a discussion in the Internationalization Teams channel.

BREAKING CHANGE: Removed support for the following numbering systems:
`bali`, `beng`, `deva`, `fullwide`, `gujr`, `guru`, `hanidec`, `khmr`,
`knda`, `laoo`, `limb`, `mlym`, `mong`, `mymr`, `orya`, `tamldec`,
`telu`, `thai`, `tibt`

---------

Co-authored-by: JC Franco <[email protected]>
@jcfranco jcfranco mentioned this issue May 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. docs Issues relating to documentation updates only. estimate - 2 Small fix or update, may require updates to tests. i18n-l10n issues dealing with internationalization/localization p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
5 participants
@jcfranco @eriklharper @geospatialem @benelan @DitwanP