Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List - arrow key navigation can get stuck #7936

Closed
2 of 4 tasks
timmorey opened this issue Oct 4, 2023 · 2 comments
Closed
2 of 4 tasks

List - arrow key navigation can get stuck #7936

timmorey opened this issue Oct 4, 2023 · 2 comments
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@timmorey
Copy link
Contributor

timmorey commented Oct 4, 2023

Check existing issues

Actual Behavior

When using arrow keys to navigate a list, you can get "stuck" in a state where up/down arrows fail to move you through the list items even though it looks like they should.

This occurs when you use the right-arrow on a list item that does not have any children. After you do this, it will still look like the list item is selected, but up/down arrows will stop working to move you through the list. Hitting the left-arrow at this time will restore the function of the up/down arrows.

This can also occur when you use the right-arrow on a list item with children that is already expanded. It seems like the list lets you left-arrow one step too far with all items.

Expected Behavior

When a list item is selected, up/down arrows should move selection through the list.

Reproduction Sample

https://codepen.io/_timmorey_/pen/YzdJrXL?editors=100

Reproduction Steps

  1. Select the first item in the list, which is an item that has children
  2. Hit right-arrow to expand. the item
  3. Hit right-arrow again, even though the item is expanded
  4. Attempt to use up/down arrows (no response)
  5. Hit left-arrow
  6. Hit down-arrow to move down to a child item
  7. Hit right-arrow on the child item
  8. Attempt to use up/down arrows (no response)

This is also reproducible in the documentation example: https://developers.arcgis.com/calcite-design-system/components/list/. My extended sample just adds a few child list items to exercise stuff more.

Reproduction Version

1.8.0

Relevant Info

Tested on Chrome Version 117.0.5938.132 (Official Build) (arm64) on MacOS 13.5.2

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

Users that prefer or rely on keyboard navigation can get into a confusing state where up/down arrow keys stop responding even though they look like they should work to move selection.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@timmorey timmorey added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 4, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. labels Oct 4, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 1, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@driskull
Copy link
Member

driskull commented Dec 2, 2023

I think this may have been fixed with #7974

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. labels Dec 4, 2023
@geospatialem
Copy link
Member

Verified in 2.0.0 per #7936 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

3 participants