Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell Panel] Outline not present when slotted in "panel-end" #7929

Closed
2 of 4 tasks
geospatialem opened this issue Oct 3, 2023 · 2 comments
Closed
2 of 4 tasks

[Shell Panel] Outline not present when slotted in "panel-end" #7929

geospatialem opened this issue Oct 3, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 December Pri...

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

There is no outline present when a shell-panel is slotted in the shell's "panel-end" slot. It is, however, depicted accurately in the "panel-start" slot and in 1.3.1.

image

Expected Behavior

Similar to the "panel-start" use and what is displayed in 1.3.1:
image

Reproduction Sample

https://codepen.io/geospatialem/pen/PoXdMGR

Reproduction Steps

  1. Open the sample
  2. Observe the lack of outline/border on the shell-panel (to the left)

Reproduction Version

1.9.0

Relevant Info

No response

Regression?

1.3.1

Priority impact

p1 - need for current milestone

Impact

Moderate - its not breaking, but visually its not great or consistent with the design system. Also a regression.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Oct 3, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. labels Oct 3, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library low risk Issues with low risk for consideration in low risk milestones and removed needs triage Planning workflow - pending design/dev review. labels Oct 3, 2023
@anveshmekala anveshmekala self-assigned this Nov 28, 2023
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 29, 2023
@anveshmekala anveshmekala mentioned this issue Dec 1, 2023
Merged
anveshmekala added a commit that referenced this issue Dec 7, 2023
@anveshmekala
fix(shell-panel): adds border at the start when slotted in panel-end (
2d1a1e2 
#8314)

**Related Issue:** #7929 

## Summary

Adds border to the `calcite-shell-panel` when slotted in `panel-end` of
`calcite-shell`.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned anveshmekala Dec 7, 2023
alisonailea pushed a commit that referenced this issue Dec 7, 2023
@anveshmekala @alisonailea
fix(shell-panel): adds border at the start when slotted in panel-end (
161502a 
#8314)

**Related Issue:** #7929 

## Summary

Adds border to the `calcite-shell-panel` when slotted in `panel-end` of
`calcite-shell`.
@geospatialem geospatialem added the estimate - 2 Small fix or update, may require updates to tests. label Dec 7, 2023
@DitwanP
Copy link
Contributor

DitwanP commented Dec 8, 2023

Verified locally on main 🍦

@DitwanP DitwanP closed this as completed Dec 8, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
4 participants
@geospatialem @DitwanP @anveshmekala @brittneytewks