Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tree] selected items should be empty in none selection mode #7909

Closed
2 of 4 tasks
jcfranco opened this issue Sep 29, 2023 · 2 comments
Closed
2 of 4 tasks

[Tree] selected items should be empty in none selection mode #7909

jcfranco opened this issue Sep 29, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 September Pr...

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

When tree is in selection-mode="none", it should emit the selection event, but not alter the selectedItems property. Doing so would be in line with the behavior introduced by calcite-dropdown.

Expected Behavior

When an item is selected, the selection event is emitted, but selectedItems should be empty.

Reproduction Sample

https://codepen.io/jcfranco/pen/vYvroZz?editors=1001

Reproduction Steps

Click on any tree item and see the console show the selected items

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. c-tree Issues that pertain to the calcite-tree and related components estimate - 2 Small fix or update, may require updates to tests. labels Sep 29, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 29, 2023
@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 29, 2023
@jcfranco jcfranco self-assigned this Sep 29, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 29, 2023
@jcfranco jcfranco mentioned this issue Sep 29, 2023
Merged
@jcfranco jcfranco removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 29, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 29, 2023
jcfranco added a commit that referenced this issue Sep 29, 2023
@jcfranco
fix(tree): avoid modifying selected items for "none" selection-mode (#…
0bd4a12 
…7904)

**Related Issue:** #7909

## Summary

`selectedItems` should no longer be updated when selection mode is
`none`.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 29, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Sep 29, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 2, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.16

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem