Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow: Support cancelling the calciteFlowItemBack event in order to prevent going back #7869

Closed
2 of 4 tasks
driskull opened this issue Sep 22, 2023 · 2 comments
Closed
2 of 4 tasks

Flow: Support cancelling the calciteFlowItemBack event in order to prevent going back #7869

driskull opened this issue Sep 22, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@driskull
Copy link
Member

driskull commented Sep 22, 2023 •
edited by geospatialem
Loading

Check existing issues

Description

Allow calciteFlowItemBack event to be cancelled in order to prevent going back

Acceptance Criteria

The cancelling of calciteFlowItemBack will prevent the back method from being called.

Relevant Info

No response

Which Component

flow, flow-item

Example Use Case

const lastFlowItem = document.querySelector("calcite-flow-item:last-of-type");
lastFlowItem?.addEventListener("calciteFlowItemBack", (event) => event.preventDefault());

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 22, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 22, 2023
@driskull driskull mentioned this issue Sep 22, 2023
Merged
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Sep 22, 2023
driskull added a commit that referenced this issue Sep 22, 2023
@driskull
feat(flow, flow-item): Allow calciteFlowItemBack event to be cancelled (
b74b4df 
#7855)

**Related Issue:**#7869

## Summary

- Supports the cancelling of the `calciteFlowItemBack` event via
`preventDefault()`
- Changes event to be cancellable
- Adds test
@driskull driskull added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Sep 22, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 22, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.7 with https://codepen.io/geospatialem/pen/JjwpJaZ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@driskull @geospatialem