Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maxItems to input-time-zone #7738

Closed
2 of 3 tasks
jcfranco opened this issue Sep 13, 2023 · 2 comments
Closed
2 of 3 tasks

Add maxItems to input-time-zone #7738

jcfranco opened this issue Sep 13, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 September Pr...

Comments

@jcfranco
Copy link
Member

jcfranco commented Sep 13, 2023 •
edited
Loading

Check existing issues

Description

calcite-input-time-zone uses calcite-combobox under the hood, so it'd be useful to add maxItems to allow users to limit the displayed items.

cc @macandcheese

Acceptance Criteria

maxItems is added to the component and matches combobox's.

Relevant Info

No response

Which Component

calcite-input-time-zone

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (dev)
@jcfranco jcfranco added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Sep 13, 2023
@jcfranco jcfranco mentioned this issue Sep 11, 2023
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2023
jcfranco added a commit that referenced this issue Sep 16, 2023
@jcfranco
feat(input-time-zone): add max-items support (#7705)
c698c27 
**Related Issue:** #7738

## Summary

Adds `maxItems` prop to allow users to define the max items to show
before displaying a scrollbar.

**Note**: this delegates max-items behavior to the internal combobox.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 16, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 18, 2023
@geospatialem
Copy link
Member

Verified in 1.9.0-next.0 with <calcite-input-time-zone max-items="10"></calcite-input-time-zone>:

verified Input Time Zone with maxItems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem