Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on a disabled button still causes a popover opening #7732

Closed
2 of 3 tasks
cont-feofanov opened this issue Sep 13, 2023 · 5 comments
Closed
2 of 3 tasks

Click on a disabled button still causes a popover opening #7732

cont-feofanov opened this issue Sep 13, 2023 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-03-26 - Mar ...

Comments

@cont-feofanov
Copy link

Check existing issues

Actual Behavior

A popover whose reference-element is a disabled calcite-button is opened on a button click.

Expected Behavior

When a reference-element a disabled then a popover should not be displayed when a disabled button was clicked.

Reproduction Sample

https://codepen.io/cont-feofanov/pen/zYyzZwN?editors=100

Reproduction Steps

See the sample

Reproduction Version

1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Business/Community Analyst
@cont-feofanov cont-feofanov added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 13, 2023
@github-actions github-actions bot added ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 13, 2023
@geospatialem
Copy link
Member

@cont-feofanov Would this workaround support the use case, where the trigger-disabled attribute would compliment the popover when the button is disabled?

@avkolomeets
Copy link

@geospatialem Thank you for the workaround, but will it be fixed in the next release? It's a regression from 1.2.0.

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library has workaround Issues have a workaround available in the meantime. estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 18, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 14, 2024
@jcfranco jcfranco self-assigned this Mar 14, 2024
@jcfranco jcfranco removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Mar 14, 2024
@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - low Issue is non core or affecting less that 10% of people using the library labels Mar 14, 2024
@jcfranco
Copy link
Member

@geospatialem Bumped the priority and updated milestone since we have a few spots where pointerdown is used instead of click, which may lead to inconsistent behavior.

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 14, 2024
@jcfranco jcfranco mentioned this issue Mar 14, 2024
Merged
jcfranco added a commit that referenced this issue Mar 21, 2024
@jcfranco
fix(action-menu, combobox, dropdown, popover, tooltip): use click ins…
cd7eed9 
…tead of pointerdown for click contexts (#8943)

**Related Issue:** #7732

## Summary

This updates event handling to use `click` vs `pointerdown` + checking
the pointer type wherever clicks are expected. Both events have
different semantics and trigger order. Simplified code is also an added
bonus.
@jcfranco jcfranco mentioned this issue Mar 22, 2024
Merged
jcfranco added a commit that referenced this issue Mar 22, 2024
@jcfranco
fix(popover): prevent disabled reference elements from toggling popov…
9f4b14b 
…er (#8983)

**Related Issue:** #7732 

## Summary

This changes `PopoverManager` to no longer rely on the capture phase for
toggling popovers, so clicks from disabled elements are ignored
properly.

**Note**: this also introduces a new DOM util to help determine if a
click event was triggered via keyboard or not.
@jcfranco jcfranco removed the 2 - in development Issues that are actively being worked on. label Mar 22, 2024
@jcfranco jcfranco added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Mar 22, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Mar 22, 2024

🍡 Verified on 2.7.0-next.14

@DitwanP DitwanP closed this as completed Mar 22, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-03-26 - Mar Release
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @avkolomeets @cont-feofanov @DitwanP