Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: update chevron colors #7710

Closed
2 of 3 tasks
Tracked by #7703
ashetland opened this issue Sep 8, 2023 · 3 comments
Closed
2 of 3 tasks
Tracked by #7703

Accordion: update chevron colors #7710

ashetland opened this issue Sep 8, 2023 · 3 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2023 November Pri...

Comments

@ashetland
Copy link
Contributor

ashetland commented Sep 8, 2023 •
edited by geospatialem
Loading

Check existing issues

Actual Behavior

When expanded, the chevron is black.

image

Expected Behavior

For system consistency, it should revert to ui-text-3.

image

Reproduction Sample

https://codepen.io/ashetland/pen/MWZpgRd

Reproduction Steps

Expand an Accordion Item.

Reproduction Version

v1.8.0

Relevant Info

Figma designs for Accordion here.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Sep 8, 2023
@ashetland ashetland mentioned this issue Sep 8, 2023
Closed
5 tasks
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Sep 8, 2023
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@geospatialem geospatialem added the good first issue Issues that can be worked on by contributors new to calcite-components. label Sep 21, 2023
@abp6318 abp6318 mentioned this issue Oct 30, 2023
Closed
@jcfranco jcfranco mentioned this issue Oct 30, 2023
Merged
jcfranco added a commit that referenced this issue Oct 31, 2023
@jcfranco @abp6318
fix(accordion-item): update expanded chevron color (#8087)
d3d7688 
# Adopted #8083
 
cc @abp6318
 
---
 
**Related Issue:**
#7710

## Summary
Updated the chevron color for accordion items to use `ui-text-3`

## Video

https://github.com/Esri/calcite-design-system/assets/60486980/1cb2302a-d869-4536-8ae5-59753a3f37c1

Co-authored-by: Aaron Putterman <[email protected]>
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Oct 31, 2023
@jcfranco jcfranco added this to the 2023 November Priorities milestone Oct 31, 2023
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem mentioned this issue Nov 1, 2023
Closed
@ashetland ashetland removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Nov 13, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 16, 2023
@geospatialem
Copy link
Member

Verified in 1.11.0-next.3. 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
6 participants
@jcfranco @geospatialem @SkyeSeitz @abp6318 @ashetland @brittneytewks