Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown group - Selection Mode doesn't apply when dynamically adding a dropdown item #7707

Closed
2 of 3 tasks
jmanke opened this issue Sep 8, 2023 · 2 comments
Closed
2 of 3 tasks

Dropdown group - Selection Mode doesn't apply when dynamically adding a dropdown item #7707

jmanke opened this issue Sep 8, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 September Pr...

Comments

@jmanke
Copy link

jmanke commented Sep 8, 2023

Check existing issues

Actual Behavior

When dynamically adding a calcite-dropdown-item under a calcite-dropdown-group with selection-mode set, the newly added item does not respect the selection-mode set in the calcite-dropdown-group.

Screenshot 2023-09-08 at 11 21 13 AM

Expected Behavior

When dynamically adding a calcite-dropdown-item under a calcite-dropdown-group with selection-mode set, the newly added item should respect the selection-mode set in the calcite-dropdown-group.

Reproduction Sample

https://codepen.io/jmanke/pen/abPJoPO?editors=1011

Reproduction Steps

  1. Open dropdown - observe dropdown items are respecting the 'none' selection mode.
  2. Click 'Add dropdown item' to dynamically add a dropdown item.
  3. Observe the newly added dropdown item is not respecting the 'none' selection mode.

Reproduction Version

1.8.0

Relevant Info

MacOS 13.4.1
Chrome 116.0.5845.140

Regression?

1.6.1

Priority impact

p2 - want for current milestone

Impact

Medium - There are many places where we dynamically add dropdown items.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Dashboards
@jmanke jmanke added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 8, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. labels Sep 8, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 18, 2023
@jcfranco jcfranco added the regression Issues that are caused by changes in a release, but were working before that. label Sep 28, 2023
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Sep 28, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 28, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. labels Sep 28, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 28, 2023
driskull added a commit that referenced this issue Sep 28, 2023
@driskull
fix(dropdown-group): set selectionMode on slotted dropdown-item child…
37a441c 
…ren. #7707
@driskull driskull mentioned this issue Sep 28, 2023
Merged
driskull added a commit that referenced this issue Sep 28, 2023
@driskull
fix(dropdown-group): set selectionMode on slotted dropdown-item child…
aa0731a 
…ren (#7897)

**Related Issue:** #7707

## Summary

- Correctly observes mutation changes and updates selectionMode on
slotted children
- Adds test
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 29, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 29, 2023
@geospatialem
Copy link
Member

Verified with 1.9.0-next.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @jmanke