Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel] No longer has border under header #7489

Closed
2 of 3 tasks
macandcheese opened this issue Aug 8, 2023 · 2 comments
Closed
2 of 3 tasks

[Panel] No longer has border under header #7489

macandcheese opened this issue Aug 8, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.6.0 - Low risk ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 8, 2023 •
edited
Loading

Check existing issues

Actual Behavior

Panel no longer has a border under a header:
Screenshot 2023-08-08 at 1 25 32 PM

Expected Behavior

I'd expect / want Panel to still have a border under header:
Screenshot 2023-08-08 at 1 25 27 PM

Reproduction Sample

Below

Reproduction Steps

Compare the two Codepen:
1.4.3 - border: https://codepen.io/mac_and_cheese/pen/qBQweyr?editors=1000
1.5.1 - no border: https://codepen.io/mac_and_cheese/pen/GRwLVGd?editors=1000

Reproduction Version

1.5.1

Relevant Info

No response

Regression?

1.4.3

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 8, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Aug 8, 2023
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Aug 8, 2023
driskull added a commit that referenced this issue Aug 8, 2023
@driskull
fix(panel): Fix heading border when only text content is slotted. #7489
62c2776
@driskull driskull mentioned this issue Aug 8, 2023
Merged
@driskull driskull self-assigned this Aug 8, 2023
@geospatialem geospatialem added this to the 1.5.2 patch - Bugs only milestone Aug 9, 2023
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Aug 9, 2023
driskull added a commit that referenced this issue Aug 9, 2023
@driskull
fix(panel): Fix heading border when only text content is slotted (#7491)
7704400 
**Related Issue:** #7489

## Summary

- Restores border-block-end by default.
- Adds internal CSS variable for temporary usage
- Issue to add panel collapsing support:
#7498
- Adds story tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 9, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 9, 2023
@geospatialem
Copy link
Member

Verified in 1.6.0-next.3

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

No branches or pull requests
3 participants
@driskull @macandcheese @geospatialem