Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-flow-item] set tooltip to open bottom by default #7433

Closed
2 of 3 tasks
lboyd93 opened this issue Aug 3, 2023 · 2 comments
Closed
2 of 3 tasks

[calcite-flow-item] set tooltip to open bottom by default #7433

lboyd93 opened this issue Aug 3, 2023 · 2 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Milestone
1.5.1 patch - Bug...

Comments

@lboyd93
Copy link

lboyd93 commented Aug 3, 2023

Check existing issues

Description

The back button on the flow item component has a tooltip that opens above by default. We would like to request the tooltip to open below by default so that we can avoid this issue in the Map Viewer and the JS Maps SDK.

flow-item-back-tooltip

cc @driskull

Acceptance Criteria

Setting the back button's tooltip to show below by default.

Relevant Info

No response

Which Component

Calcite Flow Item

Example Use Case

No response

Priority impact

p2 - want for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Maps SDK for JavaScript
@lboyd93 lboyd93 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Aug 3, 2023
@github-actions github-actions bot added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. labels Aug 3, 2023
@driskull driskull mentioned this issue Aug 3, 2023
Closed
@geospatialem geospatialem added design Issues that need design consultation prior to development. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Aug 3, 2023
@driskull driskull mentioned this issue Aug 3, 2023
Merged
driskull added a commit that referenced this issue Aug 4, 2023
@driskull
fix(flow-item): Use a native tooltip for the back button (#7442)
f38167b 
**Related Issue:** #7436 #7433

## Summary

- Use a native tooltip for the back button. #7436
- This is the only component that uses a tooltip by default so it seems
like we shouldn't do this
- A native tooltip probably makes more sense as the back icon is pretty
recognizable
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Installed and assigned for verification.

@geospatialem geospatialem added this to the 1.5.1 patch - Bugs only milestone Aug 4, 2023
@geospatialem geospatialem added low risk Issues with low risk for consideration in low risk milestones 4 - verified Issues that have been released and confirmed resolved. and removed needs triage Planning workflow - pending design/dev review. low risk Issues with low risk for consideration in low risk milestones 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 4, 2023
@geospatialem
Copy link
Member

Verified in 1.5.1-next.1, where the placement will be below the mouse cursor. Context is provided to AT users, but will not be present via keyboard keys.

verify-title-bottom-default

@SkyeSeitz SkyeSeitz removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone
Projects
None yet
Milestone
1.5.1 patch - Bugs only
Development

No branches or pull requests
6 participants
@driskull @geospatialem @lboyd93 @SkyeSeitz @ashetland @brittneytewks