Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: When content is not defined or temporarily hidden, thicker borders occur #7423

Closed
2 of 3 tasks
driskull opened this issue Aug 2, 2023 · 2 comments
Closed
2 of 3 tasks

Panel: When content is not defined or temporarily hidden, thicker borders occur #7423

driskull opened this issue Aug 2, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2023 July Priorities

Comments

@driskull
Copy link
Member

driskull commented Aug 2, 2023

Check existing issues

Actual Behavior

When the content of a panel is temporarily collapsed, a double border is seen because both the footer and heading have a border.

Expected Behavior

Ideally, if the content is not displayed, the border for the heading or action-bar is not shown.

Reproduction Sample

https://codepen.io/driskull/pen/QWJYvRm

Reproduction Steps

  1. Open the codepen
  2. See how there is a thick border when the content is not displayed
  3. This is because both the footer and the heading or action bar have a border

Reproduction Version

1.4.3

Relevant Info

N/A

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

Need to be able to collapse a panel and not have the border shown

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Maps SDK for JavaScript
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 2, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Aug 2, 2023
@driskull driskull mentioned this issue Aug 2, 2023
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Aug 2, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone Aug 2, 2023
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 2, 2023
driskull added a commit that referenced this issue Aug 2, 2023
@driskull
fix(panel): Remove double border styling when content isn't provided (#…
91a0610 
…7368)

**Related Issue:** #7423

## Summary

- Fixes display issue when no content is slotted within a panel but a
footer or action-bar is displayed then a double border occurs.
- Cleans up code to use `slotChangeHasAssignedElement` dom utility for
slot changes
- Fixes conditional element surrounding default slot.
- Adds screenshot tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 2, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 2, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.33.

benelan pushed a commit that referenced this issue Aug 3, 2023
@driskull @benelan
fix(panel): Remove double border styling when content isn't provided (#…
45101f1 
…7368)

**Related Issue:** #7423

## Summary

- Fixes display issue when no content is slotted within a panel but a
footer or action-bar is displayed then a double border occurs.
- Cleans up code to use `slotChangeHasAssignedElement` dom utility for
slot changes
- Fixes conditional element surrounding default slot.
- Adds screenshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
2 participants
@driskull @geospatialem