Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input Date Picker] In Firefox and Safari, numbering-system="latn" should change numbers in date header for "ar" to "latn" numbers #7383

Closed
2 of 3 tasks
annierm18 opened this issue Jul 26, 2023 · 2 comments
Closed
2 of 3 tasks

[Input Date Picker] In Firefox and Safari, numbering-system="latn" should change numbers in date header for "ar" to "latn" numbers #7383

annierm18 opened this issue Jul 26, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Urban Issues logged by ArcGIS Urban team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 December Pri...

Comments

@annierm18
Copy link
Contributor

annierm18 commented Jul 26, 2023 •
edited by benelan
Loading

Check existing issues

Actual Behavior

The numbers in the date header (e.g. 7/26/2023) and the value in the input appear in "arab" numbers.

Expected Behavior

The numbers should appear in "latn" numbers. This is so that the component can be consistent with the default behavior for lang="ar" in Edge and Chrome.

Reproduction Sample

https://codepen.io/ainermfc/pen/XWyxRWw?editors=100

Reproduction Steps

  1. Open the input time picker in Firefox or Safari
  2. Set the dir to rtl (not necessary)
  3. Set lang="ar"
  4. Set numbering-system="latn"

Reproduction Version

1.4.3

Relevant Info

Calcite history related to this issue can be found in the comments of #3079, e.g #3079 (comment)

This is the part in the Calcite code which handles the browser default discrepancy:

calcite-design-system/packages/calcite-components/src/utils/locale.ts

Lines 139 to 142 in 8dcfbd1

export const defaultNumberingSystem =
browserNumberingSystem === "arab" || !isNumberingSystemSupported(browserNumberingSystem)
? "latn"
: browserNumberingSystem;

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Urban
@annierm18 annierm18 added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. i18n-l10n issues dealing with internationalization/localization labels Jul 26, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Urban Issues logged by ArcGIS Urban team members. calcite-components Issues specific to the @esri/calcite-components package. labels Jul 26, 2023
@annierm18 annierm18 changed the title [Input Date Picker] In Firefox and Safari, number-systems="latn" should change numbers in date header for "ar" to "latn" numbers [Input Date Picker] In Firefox and Safari, numbering-system="latn" should change numbers in date header for "ar" to "latn" numbers Jul 26, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 21, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Sep 6, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 6, 2023
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 8, 2023
@benelan benelan mentioned this issue Dec 8, 2023
Merged
benelan added a commit that referenced this issue Dec 9, 2023
@benelan
fix(input-date-picker): respect the numberingSystem property when ren…
395b538 
…dering the input (#8383)

**Related Issue:** #7383

## Summary

- Use the numbering system specified by the property/attribute when
setting the value of the internal `calcite-input-text` component.
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 15, 2023

🍬 Verified locally on main

@DitwanP DitwanP closed this as completed Dec 15, 2023
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Dec 15, 2023
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Urban Issues logged by ArcGIS Urban team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
4 participants
@geospatialem @benelan @annierm18 @DitwanP