Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Sass mixin/function/vars/placeholder names to be kebab-case #7365

Closed
1 of 2 tasks
driskull opened this issue Jul 24, 2023 · 2 comments
Closed
1 of 2 tasks

Refactor Sass mixin/function/vars/placeholder names to be kebab-case #7365

driskull opened this issue Jul 24, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-08-27 - Aug ...

Comments

@driskull
Copy link
Member

driskull commented Jul 24, 2023 •
edited by jcfranco
Loading

Description

All sass mixin/function/vars/placeholder names should be kebab case for consistency and to follow Sass naming rules.

E.g.,

  • @mixin calciteHydratedHidden() => @mixin calcite-hydrated-hidden()

Additionally, the following stylelint-scss rules should be enabled to enforce this naming convention:

Proposed Advantages

development consistency

Which Component

All components

Relevant Info

#7346 (comment)

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 24, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Jul 24, 2023
@jcfranco jcfranco changed the title Refactor Sass mixin names to be kebab case Refactor Sass mixin/function/vars/placeholder names to be kebab-case Jul 24, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. labels Jul 24, 2023
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jan 3, 2024
@brittneytewks brittneytewks removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@Elijbet Elijbet mentioned this issue Aug 22, 2024
Merged
Elijbet added a commit that referenced this issue Aug 24, 2024
@Elijbet
refactor(stylelint): refactor to and enforce kebab-casing for Sass ut…
3c4775c 
…ilities (#10147)

**Related Issue:** #7365

## Summary
Refactor sass names to kebab-case.
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 24, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet Aug 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 26, 2024

🍭 Verified locally

@DitwanP DitwanP closed this as completed Aug 26, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
6 participants
@jcfranco @driskull @geospatialem @Elijbet @DitwanP @brittneytewks