Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-input-date-picker: throws two change events for valueAsDate #7218

Closed
AdelheidF opened this issue Jun 24, 2023 · 3 comments
Closed

calcite-input-date-picker: throws two change events for valueAsDate #7218

AdelheidF opened this issue Jun 24, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 December Pri...

Comments

@AdelheidF
Copy link

Actual Behavior

If you set the date via valueAsDate the input-date-picker component throws 2 calciteInputDatePickerChange events. This is not happening when using the value prop.

Expected Behavior

It should only throw one event if you change the date value once. Both for value and valueAsDate.

Reproduction Sample

https://codepen.io/afreitag/pen/yLPOpVY

Reproduction Steps

Open codepen and change the date once of each of the input-date-pickers. You can see that the second version throws 2 events initially.

Reproduction Version

1.4.2

Relevant Info

No response

Regression?

no

Priority impact

p2 - want for current milestone

Impact

No response

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 24, 2023
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jun 24, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 7, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@anveshmekala anveshmekala self-assigned this Oct 11, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 11, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Oct 25, 2023
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 5, 2023
@anveshmekala anveshmekala mentioned this issue Dec 6, 2023
Merged
anveshmekala added a commit that referenced this issue Dec 7, 2023
@anveshmekala
fix(input-date-picker): no longer emits redundant change event (#8341)
cd5b92b 
**Related Issue:** #7218 

## Summary

`calcite-input-date-picker` no longer emits
`calciteInputDatePickerChange` event twice when `valueAsDate` is parsed
and user changes the date.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 7, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Installed and assigned for verification.

alisonailea pushed a commit that referenced this issue Dec 7, 2023
@anveshmekala @alisonailea
fix(input-date-picker): no longer emits redundant change event (#8341)
033250b 
**Related Issue:** #7218 

## Summary

`calcite-input-date-picker` no longer emits
`calciteInputDatePickerChange` event twice when `valueAsDate` is parsed
and user changes the date.
@DitwanP
Copy link
Contributor

DitwanP commented Dec 8, 2023

Verified locally on main 🍡

@DitwanP DitwanP closed this as completed Dec 8, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 8, 2023
@AdelheidF
Copy link
Author

looks good to me too using 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
5 participants
@geospatialem @AdelheidF @DitwanP @anveshmekala @brittneytewks