Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radio-button : When tab into radio-group no radio-button is focused if the first radio-button is disabled. #7113

Closed
anveshmekala opened this issue Jun 3, 2023 · 2 comments
Closed

radio-button : When tab into radio-group no radio-button is focused if the first radio-button is disabled. #7113

anveshmekala opened this issue Jun 3, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Milestone
2023 June patch p...

Comments

@anveshmekala
Copy link
Contributor

Actual Behavior

When the first calcite-radio-button element in the group is disabled and user tries to Tab into the group then the next focusable calcite-radio-button element is not focused.

Expected Behavior

When the user Tab into a radio-group, first focusable radio-button should be focused.

Reproduction Sample

https://codepen.io/ANVESHMEKALA/pen/NWOQzxp?editors=1000

Reproduction Steps

  1. Open the codepen
  2. Try Tab into the calcite-radio-group.
  3. Observe none of the calcite-radio-button is focused.

Reproduction Version

1.4.1

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Esri team

Calcite (dev)
@anveshmekala anveshmekala added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 3, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone Calcite (dev) Issues logged by Calcite developers. labels Jun 3, 2023
@anveshmekala anveshmekala mentioned this issue Jun 5, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 5, 2023
@anveshmekala anveshmekala self-assigned this Jun 5, 2023
@anveshmekala anveshmekala changed the title radio-button : When tab into radio-group no radio-button is focused if the first button is disabled. radio-button : When tab into radio-group no radio-button is focused if the first radio-button is disabled. Jun 5, 2023
@anveshmekala anveshmekala mentioned this issue Jun 7, 2023
Merged
anveshmekala added a commit that referenced this issue Jun 21, 2023
@anveshmekala
fix(radio-button): focuses first focusable radio-button element in gr…
dd7ec60 
…oup. (#7152)

**Related Issue:** #7113 

## Summary

This PR will focus the first focusable `calcite-radio-button` when the
user `Tab` in to the group.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 21, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@anveshmekala anveshmekala removed the needs triage Planning workflow - pending design/dev review. label Jun 23, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 26, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers.
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
2 participants
@geospatialem @anveshmekala