Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite-drop-down-item label property not working as expected #6921

Closed
Vani8021 opened this issue May 4, 2023 · 3 comments
Closed

Calcite-drop-down-item label property not working as expected #6921

Vani8021 opened this issue May 4, 2023 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 July Priorities

Comments

@Vani8021
Copy link

Vani8021 commented May 4, 2023

Summary

The label property as per the documentation should be used as an accessible name. But looks like it is not working as expected. The aria-label property seems to be set only when we use the href attribute too.

Actual Behavior

label property - Not working as an accessible name.

Expected Behavior

label property - should be used to set the aria-label so that the screen readers can read them.

Reproduction Sample

https://codepen.io/geospatialem/pen/poxpyEb

Reproduction Steps

  1. Copy paste the code pen sample on Chrome or any other browser
  2. Right click to inspect the drop-down-item and look at the Accessibility Tab on the right side to look at the aria-attributes
  3. Notice the aria-label is not being set.

Reproduction Version

1.3.1

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

p1 - need for current milestone

Esri team

ArcGIS Dashboards
@Vani8021 Vani8021 added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels May 4, 2023
@github-actions github-actions bot added ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels May 4, 2023
@geospatialem geospatialem added the has workaround Issues have a workaround available in the meantime. label May 4, 2023
@geospatialem
Copy link
Member

There is a workaround where instead of using the expected label attribute, the aria-label can be substituted in its place.

Workaround is depicted in the Codepen where the first element contains the non-working label, and the second element contains an aria-label.

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels May 22, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone Jun 1, 2023
@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jun 1, 2023
@anveshmekala anveshmekala self-assigned this Jul 12, 2023
@anveshmekala anveshmekala added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 12, 2023
@anveshmekala anveshmekala mentioned this issue Jul 13, 2023
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 13, 2023
anveshmekala added a commit that referenced this issue Jul 14, 2023
@anveshmekala
fix(dropdown-item): provides accessible label when href is not parsed (…
966b83d 
…#7316)

**Related Issue:** #6921 

## Summary

This PR provides accessible label for `calcite-dropdown-item`
irrespective of `href` property value.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 14, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

benelan pushed a commit that referenced this issue Jul 18, 2023
@anveshmekala @benelan
fix(dropdown-item): provides accessible label when href is not parsed (…
28702a4 
…#7316)

**Related Issue:** #6921 

## Summary

This PR provides accessible label for `calcite-dropdown-item`
irrespective of `href` property value.
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 24, 2023
@geospatialem
Copy link
Member

Verified with JAWS with 1.5.0-next.25 with both the dropdown-item's label and aria-label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
3 participants
@geospatialem @Vani8021 @anveshmekala