Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: when filtered additional up/down arrow keystrokes required to focus past unfiltered (hidden) list-items #6736

Closed
COV-GIS opened this issue Apr 5, 2023 · 2 comments
Closed

List: when filtered additional up/down arrow keystrokes required to focus past unfiltered (hidden) list-items #6736

COV-GIS opened this issue Apr 5, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 July Priorities

Comments

@COV-GIS
Copy link

COV-GIS commented Apr 5, 2023

Actual Behavior

When a list is filtered and the up/down arrow keys are used to select list-items extra up/down keystrokes are required to focus next list-item if unfiltered (hidden) list-items are between filtered list-items.

This might also be an accessibility issue. I'm not familiar enough to say for certain.

Expected Behavior

One up/down keystroke to focus the next filtered (visible) list-item.

Reproduction Sample

https://codepen.io/COV-GIS/pen/mdzdyZq

Reproduction Steps

See sample.

Oddly, in the sample on first arrow down after filtering it skips to the second list-item. I have not observed this behavior in the component I'm working on where I noticed the behavior noted above.

Reproduction Version

1.2.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

It does not. Just reporting.

Esri team

N/A
@COV-GIS COV-GIS added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 5, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Apr 5, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Jul 19, 2023
@geospatialem geospatialem added this to the 2023 August Priorities milestone Jul 19, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Jul 19, 2023
driskull added a commit that referenced this issue Jul 27, 2023
@driskull
fix(list): fix keyboard navigation when filterEnabled is true. #6736
f43b055
@driskull driskull mentioned this issue Jul 27, 2023
Merged
driskull added a commit that referenced this issue Jul 27, 2023
@driskull
fix(list): fix keyboard navigation when filterEnabled is true (#7385)
41a2e42 
**Related Issue:** #6736

## Summary

- Updates keyboard navigable items to account for filtered items.
- Updates setFocus method to account for filter being enabled.
- Updates keyboard to account for filter navigation.
- Fixes test
- Adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned driskull Jul 27, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 28, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.28:

verify-list-filter-arrow-keys

benelan pushed a commit that referenced this issue Aug 3, 2023
@driskull @benelan
fix(list): fix keyboard navigation when filterEnabled is true (#7385)
ce87848 
**Related Issue:** #6736

## Summary

- Updates keyboard navigable items to account for filtered items.
- Updates setFocus method to account for filter being enabled.
- Updates keyboard to account for filter navigation.
- Fixes test
- Adds test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @COV-GIS