Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: disabled property for Dropdown Item #6667

Closed
olga-knyazeva opened this issue Mar 27, 2023 · 8 comments
Closed

Dropdown: disabled property for Dropdown Item #6667

olga-knyazeva opened this issue Mar 27, 2023 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. ArcGIS Urban Issues logged by ArcGIS Urban team members. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 December Pri...

Comments

@olga-knyazeva
Copy link

Description

The dropdowns in our app can have some items disabled, which is currently not possible with the CalciteDropdown component.

Acceptance Criteria

Ability to make an individual Dropdown item disabled.

Relevant Info

No response

Which Component

calcite-dropdown-item

Example Use Case

No response

Priority impact

p2 - want for current milestone

Esri team

ArcGIS Urban
@olga-knyazeva olga-knyazeva added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Mar 27, 2023
@github-actions github-actions bot added ArcGIS Urban Issues logged by ArcGIS Urban team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Mar 27, 2023
@Anastasiia-Boleiko
Copy link

Hello,

Could you please clarify what is the approximate time for having this feature in the Calcite release?

Thank you.

@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Jul 3, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jul 3, 2023
@geospatialem
Copy link
Member

Hello,

Could you please clarify what is the approximate time for having this feature in the Calcite release?

Thank you.

@Anastasiia-Boleiko Thanks for pinging this issue, we'll be assigning to a future milestone shortly.

@geospatialem geospatialem added ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 26, 2023
@geospatialem geospatialem mentioned this issue Jul 31, 2023
Closed
3 tasks
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Aug 30, 2023
@AdamWMoqrane
Copy link

AdamWMoqrane commented Sep 20, 2023 •
edited
Loading

High priority for Studio team please! (ArcGIS Knowledge)

@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - low Issue is non core or affecting less that 10% of people using the library labels Sep 20, 2023
@jcfranco jcfranco self-assigned this Dec 1, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Closed
jcfranco added a commit that referenced this issue Dec 4, 2023
@jcfranco
feat(dropdown-item): add disabled support (#8312)
4c311c6 
**Related Issue:** #6667

## Summary

This allows disabling dropdown items.
@jcfranco jcfranco removed the 2 - in development Issues that are actively being worked on. label Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 5, 2023

Verified locally on main

Waterfall option set to disabled.
image

@DitwanP DitwanP closed this as completed Dec 5, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 5, 2023
@ashetland ashetland removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 7, 2023
@DitwanP
Copy link
Contributor

DitwanP commented Dec 11, 2023

Mistake on my part , Aaron mentioned to me that although the dropdown Item is greyed out and not selectable it is still showing hover effects as well as pressed effects.

We want to remove those when an item is disabled.

Screen.Recording.2023-12-11.at.9.11.43.AM.mov

@DitwanP DitwanP reopened this Dec 11, 2023
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 4 - verified Issues that have been released and confirmed resolved. labels Dec 11, 2023
@DitwanP DitwanP assigned jcfranco and unassigned geospatialem and DitwanP Dec 11, 2023
@jcfranco jcfranco mentioned this issue Dec 11, 2023
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 11, 2023
jcfranco added a commit that referenced this issue Dec 12, 2023
@jcfranco
fix(dropdown-item): avoid hover/active styling when disabled (#8398)
35817dc 
**Related Issue:** #6667

## Summary

This addresses pseudo-element selectors kicking in due to the `disabled`
component style mixin not affecting `pointer-events` on the host (by
design).

### Notes

* Screenshot tests were not updated as our current setup does not allow
us to test for pseudo-elements. Something like
https://storybook.js.org/addons/storybook-addon-pseudo-states or
https://www.chromatic.com/docs/interactions/ might help with this in the
future.
* Related styles using `:before` were removed as they do not appear to
be in use (will submit a follow-up clean up PR afterwards).
@jcfranco jcfranco added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco jcfranco removed the 2 - in development Issues that are actively being worked on. label Dec 12, 2023
@DitwanP
Copy link
Contributor

DitwanP commented Dec 12, 2023

🍠 Looks great! Verified locally on main

Screen.Recording.2023-12-12.at.12.23.51.PM.mov

@DitwanP DitwanP closed this as completed Dec 12, 2023
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. ArcGIS Urban Issues logged by ArcGIS Urban team members. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
9 participants
@jcfranco @geospatialem @SkyeSeitz @DitwanP @olga-knyazeva @AdamWMoqrane @ashetland @brittneytewks @Anastasiia-Boleiko