Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-list missing slot for menu-action like calcite-pick-list #6600

Closed
AdelheidF opened this issue Mar 14, 2023 · 5 comments
Closed

calcite-list missing slot for menu-action like calcite-pick-list #6600

AdelheidF opened this issue Mar 14, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 July Priorities

Comments

@AdelheidF
Copy link

AdelheidF commented Mar 14, 2023 •
edited
Loading

Actual Behavior

In order to move from pick-list to list we need a way to add a menu-action like shown below.

imageimage

Expected Behavior

menu-action slot like pick-list

Reproduction Sample

https://codepen.io/afreitag/pen/WNgzWee

Reproduction Steps

Open codepen and compare the 2 lists.

Reproduction Version

1.0.8

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milstone

Impact

Needs to happen before pick-list gets removed.

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 14, 2023
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Mar 14, 2023
@AdelheidF AdelheidF mentioned this issue Mar 14, 2023
Closed
11 tasks
@AdelheidF AdelheidF added p3 - want for upcoming milestone and removed impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 13, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed p3 - want for upcoming milstone labels May 2, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 2, 2023
@geospatialem geospatialem added this to the 2023 July Priorities milestone May 2, 2023
@geospatialem
Copy link
Member

Will consider a filter-menu-options slot for the list component when a filter is present on the component.

@driskull
Copy link
Member

@jcfranco should this slot be built into the filter component? The current slot name "menu-actions" doesn't really work in the context of the list but could work in the context of the filter. We would need a better slot name for the list.

driskull added a commit that referenced this issue Jun 6, 2023
@driskull
feat(list): Add slots for filter actions. #6600
5309458
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 6, 2023
@driskull driskull mentioned this issue Jun 6, 2023
Merged
driskull added a commit that referenced this issue Jun 15, 2023
@driskull
feat(list): Add slots for filter actions (#7148)
c9215c0 
**Related Issue:** #6600

## Summary

- adds slot `filter-actions-start`.
- adds slot `filter-actions-end`.
- Uses `calcite-stack` internally for layout.
- Adds story
- Updates demo file
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 15, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Jun 15, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@driskull driskull mentioned this issue Jun 15, 2023
Merged
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 15, 2023
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 15, 2023
driskull added a commit that referenced this issue Jun 28, 2023
@driskull
feat(list): Add slots for filter actions (#7183)
da07ab1 
**Related Issue:** #6600

## Summary

- adds slot `filter-actions-start`.
- adds slot `filter-actions-end`.
- Uses `calcite-stack` internally for layout.
- Adds story
- Updates demo file
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 28, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Jun 28, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 30, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.9 with the following Codepen.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 July Priorities
Development

No branches or pull requests
3 participants
@driskull @geospatialem @AdelheidF