Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link: add ability to use outset focus outline positioning #6588

Closed
paulcpederson opened this issue Mar 13, 2023 · 6 comments
Closed

Link: add ability to use outset focus outline positioning #6588

paulcpederson opened this issue Mar 13, 2023 · 6 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.

Comments

@paulcpederson
Copy link
Member

Description

We are receiving issues where users think the focus style of the link element is a bug. The default position of the outline ring on a link is -2px inset. This means the outline overlaps the text. There is no way to customize this.

We are asking for either:

  1. The focus outline to be outset by default or
  2. Some customization mechanism like a CSS var or a prop to allow us to give the outline space around the content.

Acceptance Criteria

We should be able to have the outline at 2px offset

Relevant Info

Link actually used to use the outset focus style. d2f95a6#diff-9f60eb4702a4bb9e8e5a80c284b3695e8dba637ae48738791a6961b8de9c12c1R46

I'm not sure why it was changed, presumably some need from using the link component internally? Outset seems like a more usable default for links in the run of text.

Which Component

calcite-link

Example Use Case

Really any link use case.

Esri team

ArcGIS Online
@paulcpederson paulcpederson added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 13, 2023
@github-actions github-actions bot added the ArcGIS Online Issues logged by ArcGIS Online team members. label Mar 13, 2023
@macandcheese
Copy link
Contributor

Agree - @ashetland / @SkyeSeitz are there any places reverting to outset as the default would cause an issue? Maybe somewhere link is expected to be slotted?

@ashetland
Copy link
Contributor

Agree as well. For slotted links, looking at something like Notice /Alert, I'd expect the same behavior. Not sure why it got changed to inset.

@ashetland
Copy link
Contributor

Related issue #4633

@ashetland ashetland mentioned this issue Mar 14, 2023
Closed
7 tasks
@ashetland ashetland mentioned this issue Mar 23, 2023
Closed
@macandcheese
Copy link
Contributor

For this one in particular, we should just revert link to use outset.

@anveshmekala anveshmekala mentioned this issue Jul 19, 2023
Merged
@anveshmekala anveshmekala self-assigned this Jul 19, 2023
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 19, 2023
anveshmekala added a commit that referenced this issue Jul 20, 2023
@anveshmekala
fix(link): adds outline-offset to avoid overlapping with text. (#7342)
c30db4e 
**Related Issue:** #6588 

## Summary
This PR will add back the `2px` outline-offset for `calcite-link`.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 20, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 24, 2023
@geospatialem
Copy link
Member

Verified in 1.5.0-next.25

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@paulcpederson @macandcheese @geospatialem @anveshmekala @ashetland