Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-action-bar] bottom-actions slot name not consistent with similar slots #6517

Closed
jcfranco opened this issue Feb 24, 2023 · 2 comments
Closed

[calcite-action-bar] bottom-actions slot name not consistent with similar slots #6517

jcfranco opened this issue Feb 24, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
1.6.0 - Low risk ...

Comments

@jcfranco
Copy link
Member

Actual Behavior

All action slot names are named actions-<placement>, and bottom-actions does not follow this pattern.

Expected Behavior

bottom-actions to be renamed actions-bottom.

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/action-bar/#api-reference-slots-bottom-actions

Reproduction Steps

👀 slot name

Reproduction Version

1.0.7

Relevant Info

This name was introduced when the component got moved from the calcite-app-components repo and the name probably didn't get revisited since.

Not urgent, but we can deprecate the existing slot and introduce the new one.

Regression?

No response

Priority impact

p3 - not time sensitive

Impact

No response

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. labels Feb 24, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Feb 24, 2023
@brittneytewks brittneytewks added needs triage Planning workflow - pending design/dev review. and removed needs triage Planning workflow - pending design/dev review. labels Feb 27, 2023
@geospatialem geospatialem mentioned this issue May 2, 2023
Closed
@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels May 2, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Jul 26, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 26, 2023
@driskull driskull mentioned this issue Aug 3, 2023
Merged
driskull added a commit that referenced this issue Aug 8, 2023
@driskull
feat(action-bar): add "actions-end" slot (deprecates "bottom-actions") (
1bf14ff 
#7435)

**Related Issue:** #6517

## Summary

- Add "actions-end" slot (deprecates "bottom-actions")
- Update tests
- Update stories
- Update demos
- Update usage
- Update CSS
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 9, 2023
@geospatialem
Copy link
Member

Verified in 1.6.0-next.3 with:

<calcite-action-group slot="actions-end">

@geospatialem geospatialem added the enhancement Issues tied to a new feature or request. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
1.6.0 - Low risk issues only
Development

No branches or pull requests
5 participants
@jcfranco @driskull @alisonailea @geospatialem @brittneytewks