Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double clicking the reference element of an open popover causes unexpected placement #6404

Closed
ethanbdev opened this issue Jan 31, 2023 · 7 comments
Closed

Double clicking the reference element of an open popover causes unexpected placement #6404

ethanbdev opened this issue Jan 31, 2023 · 7 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. floating ui Issues related to floating UI impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 April Priori...

Comments

@ethanbdev
Copy link
Contributor

ethanbdev commented Jan 31, 2023 •
edited
Loading

Actual Behavior

image

Double clicking the reference element of an open popover makes it position weird, going to the top left of the screen

Expected Behavior

I would expect it to not change position at all, possibly close? Not clear

Reproduction Sample

https://codepen.io/eborgen/pen/OJwBrPK?editors=1000

Reproduction Steps

  1. Click the button to open the popover
  2. Double click the button

Reproduction Version

1.0.3

Relevant Info

Additional information:
1. This behavior also occurs on other tools.
2. This behavior also occurs on FF/Safari/Edge chromium browsers.

Test case:
https://github.com/ArcGIS/I18N-BYS-TestCases/issues/10286

Configuration:
1. Build: AGOL 2023.1 devext site
2. OS: ENU Win 10
3. Browser: Chrome (109.0.5414.120)
4. Found by date: 1/31/2023

Build Number : 1/31/2023

Regression?

No response

Impact

Its pretty consistent and easy for a user to accidentally do this

Esri team

ArcGIS Map Viewer
@ethanbdev ethanbdev added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 31, 2023
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Jan 31, 2023
@ethanbdev
Copy link
Contributor Author

Also repro'd in the calcite components public doc site: https://developers.arcgis.com/calcite-design-system/components/popover/

@macandcheese
Copy link
Contributor

Adding on, this issue (or an issue somewhat similar to it), is also evident in the component sample app UI itself, but with Tooltip.

Quickly double clicking the Action Bar Actions can occasionally cause the Tooltip to reposition and in that case, appear cutoff:
Screen Shot 2023-01-31 at 8 59 39 PM

Not 100% the same but another weird Floating UI thing, might help diagnose.

@ethanbdev ethanbdev added ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members and removed ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. labels Feb 1, 2023
@amring1
Copy link

amring1 commented Feb 8, 2023

Can we get a timeline on a fix for this? It's frustrating for many of our analysis components.

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Mar 29, 2023
@geospatialem
Copy link
Member

Adding priority labels, which weren't available at the time of issue creation.

Priority is mentioned since it was an issue reported by support, and aiming to get a resolution as soon as possible.

@geospatialem geospatialem added floating ui Issues related to floating UI 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 29, 2023
@geospatialem geospatialem added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Mar 29, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Mar 31, 2023
@jcfranco jcfranco mentioned this issue Mar 31, 2023
Merged
@jcfranco
Copy link
Member

This is scheduled for the April milestone. For now, setting overlay-positioning="fixed" can be used as a workaround.

@jcfranco jcfranco mentioned this issue Mar 31, 2023
Closed
jcfranco added a commit that referenced this issue Apr 13, 2023
@jcfranco
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix mis…
e220686 
…placed floating-ui elements when associated-components are closed (#6709)

**Related Issue:** #6404

## Summary

This removes a utility added in
#5484 that would reset
position of floating-UI elements using the absolute strategy to avoid
scroll bars when hidden. Unfortunately, the util would lead to undesired
position resets in some scenarios (e.g., quick toggling between
transitions). Moving forward, it is recommended to use
`overlay-positioning='fixed'`to escaping clipping containers and prevent
hidden floating-ui elements from affecting layout/creating scrollbars.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Apr 13, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Apr 13, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Apr 13, 2023
@geospatialem
Copy link
Member

Verified in 1.3.0-next.4

veridy-double-click-popover-fix

@jcfranco jcfranco mentioned this issue Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. ArcGIS Web Analysis Issues logged by ArcGIS Web Analysis team members bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. floating ui Issues related to floating UI impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 April Priorities - No breaking c...
Development

No branches or pull requests
6 participants
@jcfranco @alisonailea @macandcheese @geospatialem @ethanbdev @amring1