Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[date-picker]: rounds up all remaining styling bugs #6321

Closed
1 of 5 tasks
Elijbet opened this issue Jan 20, 2023 · 6 comments
Closed
1 of 5 tasks

[date-picker]: rounds up all remaining styling bugs #6321

Elijbet opened this issue Jan 20, 2023 · 6 comments
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-05-28 - May ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jan 20, 2023 •
edited by geospatialem
Loading

Actual Behavior

Rounds up all remaining styling bugs on date-picker:

  • Hover starts selecting from the beginning of the month (Input Date Picker Range: start date's hover style starts at the beginning of the month #6194)
  • Unwanted blue gradient highlight when hovering/active/selected on the start-range date
  • Same behavior when the start-range date is selected and the end-range is being hovered/active/selected
  • Hovering/active past end-range also creates an unwanted white highlight over the grey gradient
  • All these issues are true and need to be addressed for both rtl and ltr

1__213818983-9019a308-aaa1-4668-9573-21b1de5411a1

2__213818984-ae875dcf-48a2-45fb-a92e-9463783166f8

3__213818980-5b3eb4ba-efb9-44a8-ad14-fe6c14c14956

Expected Behavior

Remove the highlight.

Reproduction Sample

See demo.

Reproduction Steps

N/A

Reproduction Version

v1.0.0-beta.99

Relevant Info

No response

Regression?

No response

Impact

No response

Esri team

Calcite (dev)
@Elijbet Elijbet added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 20, 2023
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Jan 20, 2023
@alisonailea alisonailea changed the title [date-picker]: rounds up all remaining styling bugs [date-picker]: rounds up all remaining styling bugs Feb 12, 2023
@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Mar 30, 2023
@geospatialem
Copy link
Member

geospatialem commented Mar 30, 2023 •
edited
Loading

Need design expertise and input across the date-picker component.

Recommendation should also list the priority of items to tackle.

@geospatialem geospatialem added the c-datepicker Issues that pertain to the calcite-date-picker component label Mar 30, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. estimate - 8 Requires input from team, consider smaller steps. labels May 2, 2023
@geospatialem geospatialem added this to the Design Sprint Next milestone Jun 1, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. 0 - new New issues that need assignment. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 1, 2023
@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Sep 8, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

cc @geospatialem, @brittneytewks

@github-actions github-actions bot removed this from the Design Next milestone Sep 8, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Nov 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@jcfranco
Copy link
Member

@Elijbet Can you confirm the reported styling issues are still present in the latest release? #7872 made several changes to date-picker and addressed some styling quirks.

@geospatialem
Copy link
Member

The above has already been covered per #6321 (comment), or will be covered in #3455, targeted for this release in May 2024. Closing the above.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
@anveshmekala anveshmekala mentioned this issue May 22, 2024
Merged
anveshmekala added a commit that referenced this issue Oct 23, 2024
@anveshmekala
feat(input-date-picker, date-picker): improve date picking experience (…
24d43ad 
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
@anveshmekala anveshmekala self-assigned this Oct 23, 2024
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Oct 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component Calcite (dev) Issues logged by Calcite developers. design Issues that need design consultation prior to development. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
9 participants
@jcfranco @alisonailea @geospatialem @Elijbet @SkyeSeitz @DitwanP @anveshmekala @ashetland @brittneytewks