Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-dropdown: open dropdown not moving on scroll after re-ordering blocks #6121

Closed
AdelheidF opened this issue Dec 20, 2022 · 6 comments
Closed

calcite-dropdown: open dropdown not moving on scroll after re-ordering blocks #6121

AdelheidF opened this issue Dec 20, 2022 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
2023 December Pri...

Comments

@AdelheidF
Copy link

AdelheidF commented Dec 20, 2022 •
edited
Loading

Actual Behavior

Before re-ordering blocks the open dropdown moves along with the panel when scrolling via mouse wheel.
After re-ordering blocks the open dropdown stays in place.

cc @driskull

Expected Behavior

open dropdown always moves with the panel scroll

Reproduction Sample

https://codepen.io/afreitag/pen/RwBbgxK

Reproduction Steps

  1. open "Preview count" dropdown and scroll panel via mouse wheel, watch the open dropdown move correctly
  2. re-order block C before block B
  3. now again open "Preview count" dropdown and scroll panel, notice the open dropdown sticks in place

Reproduction Version

beta.99

Relevant Info

No response

Regression?

don't think so

Impact

medium

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 20, 2022
@github-actions github-actions bot added the ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. label Dec 20, 2022
@geospatialem geospatialem added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Feb 28, 2023
@geospatialem
Copy link
Member

Additional research is needed, there may be a workaround related to the #6520 PR.

@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Feb 28, 2023
@geospatialem geospatialem added this to the Stalled milestone Feb 28, 2023
@driskull
Copy link
Member

@AdelheidF is this issue still present?

@lau11123
Copy link

lau11123 commented Jul 4, 2023

@driskull yeah, it's still an issue.

@driskull driskull self-assigned this Nov 29, 2023
driskull added a commit that referenced this issue Nov 29, 2023
@driskull
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix pos…
c625644 
…itioning of component when component is moved. #6121
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 29, 2023
@driskull driskull mentioned this issue Nov 29, 2023
Merged
driskull added a commit that referenced this issue Nov 29, 2023
@driskull
fix(combobox, dropdown, input-date-picker, popover, tooltip): fix pos…
2b2506d 
…itioning of component when component is moved (#8296)

**Related Issue:** #6121

## Summary

- When a component is moved (via drag and drop or whatever), we need to
reconnect floating UI (connectFloatingUI).
- This is needed because it sets up autoUpdating of the reference
element so that the reference element is tracked and positioned properly
- Currently, when an a component is moved, this tracking is lost because
we were only calling `connectFloatingUI` when the reference element and
floating element were created.
- This PR makes sure that we reestablish the floating UI autoUpdate when
the component itself is moved.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 29, 2023
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed blocked This issue is blocked by another issue. research Issues that require more in-depth research or multiple team members to resolve or make decision. needs triage Planning workflow - pending design/dev review. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2023
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Dec 1, 2023
@geospatialem
Copy link
Member

Verified in 1.12.0-next.6.

@AdelheidF
Copy link
Author

Looking good for me too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
6 participants
@driskull @alisonailea @geospatialem @AdelheidF @DitwanP @lau11123