-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropdown button with width="full" wider than containing block #5903
Comments
Could this be part of 1.0? |
How smart do you want this to be; are you expecting it to understand word breaks such as, capitalization, underscores, periods, etc.
Or just wrap on the overflow
|
I think this is fine. Don't you do this already in other places like this? |
I believe so. Although interestingly, it currently understands hyphens as word breaks and wraps there. |
@AdelheidF We're putting this in a list for Franco when he returns, but due to staffing, this one might land in time for the February release. Will post an update a few weeks into 2023. |
Seeking design expertise for the |
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
Installed an update to |
Installed and assigned for verification. |
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
Verified with |
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
…up (#8253) **Related Issue:** #5903 ## Summary BREAKING CHANGE: Dropdown's default `display` was changed from `inline-flex` to `inline-block` to make it easier to prompt truncation in trigger button text with minimal impact to layout (by setting an explicit width **or** setting `width: 100%` or `display: block` on the dropdown of a width-constrained parent).
I tested this fix now with the original (simple) codepen and it seems fixed with 2.0. But when I look at it in Map Viewer it's still not working. I updated the codepen to display the issue in the right-side flow. It seems that if the https://codepen.io/afreitag/pen/GRGPdwQ; This workaround no longer works either
|
Nice, this works. I will use that. Is this a workaround or the solution? Basically do you want me to close this issue again? |
This would be the solution. The recent change to dropdown makes truncation easier to set up, but we can't handle all cases as it depends on the HTML structure. |
Actual Behavior
The dropdown button is wider than its containing block if the button text has no dashes or spaces.
Button uses
width="full"
.Expected Behavior
text is wrapped
Reproduction Sample
https://codepen.io/afreitag/pen/GRGPdwQ
Reproduction Steps
open codepen and observe. Red box displays block dimensions.
Reproduction Version
next.657
Relevant Info
No response
Regression?
Don't think so
Impact
No response
Esri team
ArcGIS Map Viewer
The text was updated successfully, but these errors were encountered: