Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: stepper item events #2094

Closed
joeyHarig opened this issue May 4, 2021 · 7 comments
Closed

Enhancement: stepper item events #2094

joeyHarig opened this issue May 4, 2021 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-stepper Issues that pertain to the calcite-stepper component enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-05-28 - May ...

Comments

@joeyHarig
Copy link
Contributor

Description

The calcite-stepper-item component does not emit any events on click or keypress. Our implementations of the stepper component in ArcGIS Monitor require us to watch for when a stepper item becomes active inorder to determine which step to render within the form adjacent to the stepper component.

Acceptance Criteria

Add an event to calcite-stepper-item that triggers on click, enter keypress and spacebar keypress
ex. onCalciteStepperItemActive

Which Component

calcite-stepper-item

Example Use Case

Screen Shot 2021-05-04 at 1 18 06 PM

Screen Shot 2021-05-04 at 1 16 47 PM
@joeyHarig joeyHarig added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. labels May 4, 2021
@benelan benelan added the needs triage Planning workflow - pending design/dev review. label Sep 27, 2021
@benelan benelan added this to the Back burner milestone Oct 13, 2021
@nwhittaker
Copy link
Contributor

nwhittaker commented Apr 25, 2022 •
edited
Loading

Ran into a scenario where this event would've been helpful. For example, if the user should visit each step in order, but can revisit a past step at any time, the program can lose track of which is the active step when the user clicks a previous stepper title.

@brittneytewks brittneytewks removed this from the Back burner milestone May 31, 2023
@geospatialem geospatialem added the estimate - 3 A day or two of work, likely requires updates to tests. label Aug 21, 2023
@geospatialem
Copy link
Member

Emit on stepper/stepper-item change, rather than on click/hover.

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 21, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Dec 6, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 6, 2023
@brittneytewks brittneytewks added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Mar 25, 2024
@brittneytewks brittneytewks removed this from the 2024-04-30 - Apr Release milestone Mar 25, 2024
@geospatialem geospatialem added this to the 2024-12-17 - Dec Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@macandcheese macandcheese added the c-stepper Issues that pertain to the calcite-stepper component label Apr 29, 2024
@jcfranco
Copy link
Member

@joeyHarig @nwhittaker I believe #9351 would take care of this. Can you confirm?

@nwhittaker
Copy link
Contributor

I believe #9351 would take care of this. Can you confirm?

Yes, I believe so, if it also emits when the user clicks on the stepper's heading.

This was referenced May 17, 2024
Merged
Closed
@jcfranco jcfranco self-assigned this May 17, 2024
@jcfranco jcfranco removed the 0 - new New issues that need assignment. label May 17, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. p - medium Issue is non core or affecting less that 60% of people using the library and removed p - low Issue is non core or affecting less that 10% of people using the library labels May 17, 2024
@jcfranco
Copy link
Member

Awesome. Thanks for confirming!

@jcfranco jcfranco changed the title Enhancement: stepper item events Enhancement: stepper and stepper item events May 17, 2024
@jcfranco jcfranco changed the title Enhancement: stepper and stepper item events Enhancement: stepper item events May 17, 2024
jcfranco added a commit that referenced this issue May 23, 2024
@jcfranco
feat(stepper, stepper-item): add separate change events to stepper an…
cf6a118 
…d items (deprecates `calciteStepperItemChange` on the parent) (#9351)

**Related Issue:** #2094 

## Summary

Adds the following events:

* `calciteStepperChange` on `calcite-stepper`
* `calciteStepperItemChange` on `calcite-stepper-item`

Deprecates `calciteStepperItemChange` on `calcite-stepper`.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco May 23, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 23, 2024
@geospatialem
Copy link
Member

Verified in 2.9.0-next.22 with https://codepen.io/geospatialem/pen/YzbWgQV.

Includes two new events:

  • stepper: calciteStepperChange
  • stepper-item: calciteStepperItemSelect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-stepper Issues that pertain to the calcite-stepper component enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
9 participants
@jcfranco @nwhittaker @alisonailea @macandcheese @geospatialem @benelan @joeyHarig @DitwanP @brittneytewks