Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: step support for time picker components #1529

Open
eriklharper opened this issue Feb 9, 2021 · 3 comments
Open

Enhancement: step support for time picker components #1529

eriklharper opened this issue Feb 9, 2021 · 3 comments
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request.
Milestone

Comments

@eriklharper
Copy link
Contributor

Description

Add support for the step attribute/property for calcite-time-picker and calcite-input-time-picker. Functionality should probably match what the native time input does in Chromium.

Acceptance Criteria

Both time-picker components support the step attribute as specified by the most popular browser implementations. Involve design on how best to implement this as well.

Relevant Info

Docs on the step attribute
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-step

Codepen demonstrating all the available options for step that change the behavior of the time input (not all values work).
https://codepen.io/eriklharper/pen/abBmOGz?editors=1010

Which Component

calcite-time-picker
calcite-input-time-picker

Example Use Case

@eriklharper eriklharper added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. labels Feb 9, 2021
@julio8a julio8a added this to the Backlog milestone Jul 16, 2021
@macandcheese
Copy link
Contributor

@eriklharper - looks like step is available in the component - can this be closed?

@eriklharper
Copy link
Contributor Author

eriklharper commented Aug 23, 2021

@eriklharper - looks like step is available in the component - can this be closed?

step is technically available, but it doesn't exactly function as intended for every possible step value. There currently are not enough sufficient unit tests for all the possible step values (we're currently only testing step="1" to allow seconds input) so we should keep this issue open to not only add the missing tests for the various step values we want to support. but deciding which values we should support and why. The native time inputs in browsers like Chromium only support certain step values, and we have not yet built and tested that support into the time components. Click the codepen link I posted above to see the step values that actually take effect in the native time inputs on Chrome. Any value that is missing from that example doesn't actually do anything.

@macandcheese
Copy link
Contributor

@eriklharper cool, thanks for the context, was just doing some cleanups 🧹

@benelan benelan added the Calcite (dev) Issues logged by Calcite developers. label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

6 participants