Add dashboard icon and set workforce project icon #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to add the actual icon in I think it would be time well spent to try and break the item type/icon mapping into its own file to make these kinds of updates easier going forward. |
|
The I wasn't super familiar with code base and thought it was pretty straight-forward to make this update...just my thoughts. |
|
I see it now. I somehow overlooked it when viewing the commit the first time. I also forgot we already broke the item types into a json file. 😳 Sorry about the false alarms! |
|
thanks @apulverizer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dashboard icon as used by ArcGIS Online for
Dashboarditems. It also maps theWorkforce Projecttype to show the map icon (which is what AGOL uses).