New dev tooling and build process #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to simplify and strengthen the build process.
No longer needed.
Best practice
This was previously added in #f87357f and is needed for old browsers (looking at you IE11).
Show relevant resources.
Cross platform support in the build scripts.
Windows wasn't following the paths correctly when trying to copy files.
cross-env is required to handle the difference in environment variables ($ on unix and % on Windows).
Moved babel-polyfill to dependencies since it is required and updated minimum version of node for better library support.
rwmajor2
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #198, this PR replaces Grunt with vanilla npm scripts. Grunt had a great run and served this project well, but this should simplify things a great deal. Thanks to @rwmajor2 for all of the help debugging this and ensuring the build works on both Windows and Unix environments.
A summary of the changes:
appIdandportalUrl) fromconfig.jsonintopackage.jsonmain.jsthrough babel so we can start to use some of the fun syntax in es2015Anybody doing dev on this project will need to run
npm installandnpm pruneto update the local libraries required for this app.I did not yet include prettier because it would have made merging the existing PRs difficult. Once all of those have been merged, we can look at leveraging prettier prior to new PRs (as well as softening the linting rules).
One shortcoming of the new dev tooling is the lack of a "watch" component added by @gbochenek in #171. I gave it a shot, but could not successfully configure watch. Maybe somebody else will have better success.