WIP Fail in processSequenceBatches if we don't have the parent batch #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause an error if there has been a reorg since we fetched the batches. In normal mode, this should never happen, since we check for reorgs and then fetch batches synchronously. But in preconfirmations mode, the batches are fetched asynchronously wrt to the reorg detection, and so the L2 head can change under us. In this case the new check will fail and we will re-fetch preconfirmations after checking the new L2 head. Fixes EspressoSystems/espresso-polygon-zkevm-demo#246
jbearer
force-pushed
the
fix/preconf-reorgs
branch
from
24f34c1 to
a05c779
Compare
|
Finally have a test for this, and it doesn't work, because, as I learned recently, SQL transactions aren't exclusive. So it is possible for the DB to get reset in between doing this check and processing the batch. Anyways, I decided it was better to explicitly synchronize with the preconf task whenever we are about to reset the DB, rather than try to detect it after it happens. That fix is in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause an error if there has been a reorg since we fetched the batches. In normal mode, this should never happen, since we check for reorgs and then fetch batches synchronously. But in preconfirmations mode, the batches are fetched asynchronously wrt to the reorg detection, and so the L2 head can change under us. In this case the new check will fail and we will re-fetch preconfirmations after checking the new L2 head.
Fixes EspressoSystems/espresso-polygon-zkevm-demo#246