Support optional parameters. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes a panic in request parsing when a formal parameter from another route pattern is not specified * Fixes some redundancy in route spec parsing * Removes `RequestParam::required`, as it is not used and not really meaningful (a parameter is required relative to a particular route pattern, but a route can have many patterns, and Tide already ensures that all the parameters for a given pattern are present before dispatching to that pattern) * Adds a new test Closes #37
nyospe
reviewed
Aug 22, 2022
| })) | ||
| }) | ||
| .collect::<Result<_, _>>()?, | ||
| params: params.into_values().collect(), |
nyospe
approved these changes
Aug 22, 2022
|
Haha yeah...I was surprised when I saw that...and I wrote it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another route pattern is not specified
RequestParam::required, as it is not used and not reallymeaningful (a parameter is required relative to a particular route
pattern, but a route can have many patterns, and Tide already
ensures that all the parameters for a given pattern are present
before dispatching to that pattern)
Closes #37