Improve request parameter ergonomics. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `integer_param` has a polymorphic return type, inferred from the calling context * add getters for optional parameters that return Option or Result<Option> so that request handlers can easily distinguish between error cases and "not provided" cases
nyospe
reviewed
Aug 22, 2022
src/request.rs
Outdated
| self.opt_param(name) | ||
| .map(|val| { | ||
| val.as_integer().context(IncorrectParamTypeSnafu { | ||
| name: name.to_string(), |
There was a problem hiding this comment.
So, one way this could fail is if the TryFrom<u128> fails. As I recall, the Snafu can incorporate the original error... is extracting it going to give us enough information to match the old IntegerOverflow case? Can we include the value of the enum as well as its type somehow?
There was a problem hiding this comment.
That's a good point. I think the correct way to handle this is to have all the as_* functions return Result<_, RequestError> rather than Option<_>. These functions only ever fail if a conversion, fails, so there is no reason not to return an error in those cases. Then the *_param functions can just propagate the error.
nyospe
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integer_paramhas a polymorphic return type, inferred from thecalling context
Result so that request handlers can easily distinguish
between error cases and "not provided" cases