Parse and populate route parameters #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbearer
approved these changes
Jun 19, 2022
Comment on lines
+204
to
+205
| // TODO Should the map key and name be different? If | ||
| // not, then RequestParam::name is redundant. |
There was a problem hiding this comment.
You're right, RequestParam::name is probably redundant
| RequestParam { | ||
| name: seg.to_string(), | ||
| param_type: ptype, | ||
| // TODO How should we encode optioanl params? |
There was a problem hiding this comment.
I was thinking for now we would just check if the parameter appears in every pattern for the route. If so, it is "required".
I think later on, we should separate parameter declarations from route patterns, something like:
":my_param" = { type = "TaggedBase64", doc = "A parameter", optional = true }
and then allow parameters to be passed by URL segment, URL param, or request body.
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.