Updating with StaticVersionType #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
reviewed
Mar 13, 2024
examples/hello-world/main.rs
Outdated
| @@ -39,11 +43,11 @@ impl From<RequestError> for HelloError { | |||
| } | |||
|
|
|||
| async fn serve(port: u16) -> io::Result<()> { | |||
| let mut app = App::<_, HelloError, 0, 1>::with_state(RwLock::new("Hello".to_string())); | |||
| let mut app = App::<_, HelloError, Ver01>::with_state(RwLock::new("Hello".to_string())); | |||
There was a problem hiding this comment.
I'm not really familiar with the code in this repo, but it looks like there are multiple different names for the same thing. Is this intentional?
There's Ver01 here.
There was a problem hiding this comment.
It's not so much intentional as the inevitable consequence of how rust's doctest works. Each doctest instance is basically its own isolated sandbox. Likewise for examples. There's nothing special about these aliases, they're just convent for illustrating that, in real usage, you would be using something external rather than hardcoding StaticVersion<0, 1> as a parameter.
| /// # const MINOR: u16 = 1; | ||
| /// # fn ex(api: &mut tide_disco::Api<(), (), MAJOR, MINOR>) { | ||
| /// # use versioned_binary_serialization::version::StaticVersion; | ||
| /// # type StaticVer01 = StaticVersion<0, 1>; |
src/api.rs
Outdated
| @@ -1376,7 +1386,7 @@ mod test { | |||
|
|
|||
| #[async_std::test] | |||
| async fn test_socket_endpoint() { | |||
| let mut app = App::<_, ServerError, 0, 1>::with_state(RwLock::new(())); | |||
| let mut app = App::<_, ServerError, StaticVersion01>::with_state(RwLock::new(())); | |||
There was a problem hiding this comment.
Just three different contexts, each with a local alias...
jbearer
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One positive here is, I've figured out how to bind the version from the sequencer to HotShot, such that we can schedule updates without changing HotShot if we need to.