Revert "Revert "temp dir""

This reverts commit b47f294.

Cargo.toml

@@ -66,7 +66,7 @@ tracing-log = "0.2"
 tracing-subscriber = { version = "0.3.18", features = ["env-filter", "json"] }
 url = "2.5.0"
 vbs = "0.1"
-rand = "0.8"
+tempdir = "0.3"
 
 # Dependencies enabled by feature `testing`
 async-compatibility-layer = { version = "1.1", features = ["logging-utils"], optional = true }

src/app.rs

@@ -22,7 +22,6 @@ use futures::future::{BoxFuture, FutureExt};
 use include_dir::{include_dir, Dir};
 use lazy_static::lazy_static;
 use maud::{html, PreEscaped};
-use rand::Rng;
 use semver::Version;
 use serde::{Deserialize, Serialize};
 use serde_with::{serde_as, DisplayFromStr};
@@ -36,6 +35,7 @@ use std::{
     ops::{Deref, DerefMut},
     path::PathBuf,
 };
+use tempdir::TempDir;
 use tide::{
     http::headers::HeaderValue,
     security::{CorsMiddleware, Origin},
@@ -270,14 +270,13 @@ impl<State: Send + Sync + 'static, Error: 'static> App<State, Error> {
 static DEFAULT_PUBLIC_DIR: Dir<'_> = include_dir!("$CARGO_MANIFEST_DIR/public/media");
 lazy_static! {
     static ref DEFAULT_PUBLIC_PATH: PathBuf = {
-        // Generate a random number to index into `/tmp` with
-        let mut rng = rand::thread_rng();
-        let index: u64 = rng.gen();
+        // Create a randomly generated temporary directory to extract the public directory into
+        let temp_dir = TempDir::new("tide-disco").expect("failed to create temporary directory");
 
         // The contents of the default public directory are included in the binary. The first time
         // the default directory is used, if ever, we extract them to a directory on the host file
         // system and return the path to that directory.
-        let path = PathBuf::from(format!("/tmp/tide-disco/{}/public/media", index));
+        let path = temp_dir.path().to_path_buf();
         // If the path already exists, move it aside so we can update it.
         let _ = fs::rename(&path, path.with_extension("old"));
         DEFAULT_PUBLIC_DIR.extract(&path).unwrap();