Misc small testnode fixes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `develop` branch of nitro-contracts - Remove `node.espresso` argument that was removed in nitro - Remove trailing `-f` argument from docker build command - Default to `leveldb` db backend to avoid panic from new default backend `pebble`.
sveitser
requested review from
ImJeremyHe,
nomaxg,
alysiahuggins,
zacshowa and
Sneh1999
as code owners
Sneh1999
approved these changes
Aug 8, 2024
I don't know. Thanks for asking. I just noticed the panic happens here: https://github.com/EspressoSystems/nitro-espresso-integration/blob/ad339ce4b86e9f4060e19f25a43aeedc9a130267/arbnode/transaction_streamer.go#L1032 which is code we added for persistence. |
|
Will merge this since it helps. Opened a new issue for investigating what's wrong: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close EspressoSystems/nitro-espresso-integration#185
developbranch of nitro-contracts, the branch we develop onnode.espressoargument that was removed in nitro-fargument from docker build commandleveldbdb backend to avoid panic from new default backendpebble.