Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the staker and contract deployment #37

Merged
merged 27 commits into from
Jul 23, 2024
Merged

Fix the staker and contract deployment #37

merged 27 commits into from
Jul 23, 2024

Conversation

ImJeremyHe
Copy link
Member

@ImJeremyHe ImJeremyHe commented Jul 19, 2024

This will be a draft PR until EspressoSystems/nitro-contracts#10 is merged.

This PR:

  • Sync upstream
  • Deploy the espresso nitro contracts instead of the original ones
  • Update the espresso-dev-node

How to test:

Run this command

./test-node.bash --init --no-simple --espresso --latest-espresso-image

to see if the our contracts has been deployed and the staker is up or not.

Remaining issues:

Currently the staker has these error logs:

nitro-testnode-staker-unsafe-1 | INFO [07-19|05:36:34.663] rpc response method=eth_estimateGas logId=1102 err="err: max priority fee per gas higher than max fee per gas: address 0x6A568afe0f82d34759347bb36F14A6bB171d2CBe, maxPriorityFeePerGas: 1500000000, maxFeePerGas: 1000000000 (supplied gas 8767444)" result=""0x0"" attempt=0 args="[{"from":"0x6a568afe0f82d34759347bb36f14a6bb171d2cbe","input":"0x097da1f8000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000bbc04956031f64be7ad7b5489ce2433e0238a2a0000000000000000000000000000000000000000000000000de0b6b3a764000000000000000000000000000000000000000000000000000000000000000001e44023cc4f00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000127b153d4ed7f45ce3f0c716ca5ea7c24483dc86f7eeb9af31fe5e60a9fab35a800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000f5000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000fff3a2569dc98afc4bade748c837b9ea8478e99b0814dc4314689007fb48b30e92000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000","maxFeePerGas":"0x3b9aca00","maxPriorityFeePerGas":"0x59682f00","to":"0x139a0b6b1dd1e7f912361b32a09cad89e82f29db","value":"0xde0b6b3a7640000"}]" errorData=null
nitro-testnode-staker-unsafe-1 | ERROR[07-19|05:36:34.663] error acting as staker err="getting gas for tx data: estimating gas: err: max priority fee per gas higher than max fee per gas: address 0x6A568afe0f82d34759347bb36F14A6bB171d2CBe, maxPriorityFeePerGas: 1500000000, maxFeePerGas: 1000000000 (supplied gas 8767444)"

It looks like the transaction failed because of the gas fee related configuration. Not sure which part of the code set the wrong settings. Will check it again after publish the latest image

gvladika and others added 27 commits January 8, 2024 11:29
Support for non-18 decimals in custom fee token
Bump nitro-contracts and token-bridge
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ gvladika
❌ tsahee
❌ gzeoneth
You have signed the CLA already but the status is still pending? Let us recheck it.

@ImJeremyHe ImJeremyHe changed the title Jh/fix Fix the staker and contracts deployment Jul 19, 2024
@ImJeremyHe ImJeremyHe changed the title Fix the staker and contracts deployment Fix the staker and contract deployment Jul 19, 2024
@sveitser sveitser requested review from nomaxg, zacshowa and Sneh1999 July 19, 2024 08:23
@sveitser sveitser marked this pull request as draft July 19, 2024 08:24
@sveitser
Copy link
Collaborator

@ImJeremyHe also not sure where the relevant maxPriorityFeePerGas is set. If you keep the staker running do those values get updated or do you always get exactly the same error message?

@ImJeremyHe
Copy link
Member Author

ImJeremyHe commented Jul 19, 2024

@ImJeremyHe also not sure where the relevant maxPriorityFeePerGas is set. If you keep the staker running do those values get updated or do you always get exactly the same error message?

Will always get the same errors. I am thinking maybe some subtle things changed in the upstream and we haven't updated yet. And this repo has synced the upstream.

@ImJeremyHe ImJeremyHe marked this pull request as ready for review July 23, 2024 02:32
@ImJeremyHe
Copy link
Member Author

#40 . Merge this first to fix the contracts CI

@ImJeremyHe ImJeremyHe merged commit c712daf into integration Jul 23, 2024
0 of 2 checks passed
@ImJeremyHe ImJeremyHe deleted the jh/fix branch July 23, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants