Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix the testnode #34

Merged
merged 252 commits into from
Jul 9, 2024
Merged

Update and fix the testnode #34

merged 252 commits into from
Jul 9, 2024

Conversation

ImJeremyHe
Copy link
Member

@ImJeremyHe ImJeremyHe commented Jul 8, 2024

This PR:

  • Sync with the upstream(not sure if this is necessary for fixing the test node. Fortunately it works and it should be better having the latest version)
  • Fix the nitro test node

Key places to review

config.ts

How to test this PR:

In the nitro-integration repo, change the submodule path to this branch (jh/dev-node) and update the submodule

git submodule update --remote nitro-testnode

and

cd nitro-testnode && \
 ./test-node.bash --init --dev --espresso --validate

Run the command above and wait for about 5 mins, if the validator works normally then it is good.

gvladika and others added 30 commits August 22, 2023 13:33
iAlso don't deploy token bridge in fee token mode
initialize required config fields wrt current nitro
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 7 committers have signed the CLA.

✅ sveitser
✅ tbro
✅ nomaxg
❌ gvladika
❌ tsahee
❌ diegoximenes
❌ ariskk
You have signed the CLA already but the status is still pending? Let us recheck it.

@ImJeremyHe ImJeremyHe merged commit d50e075 into release Jul 9, 2024
0 of 2 checks passed
@ImJeremyHe ImJeremyHe deleted the jh/dev-node branch July 9, 2024 01:51
@ImJeremyHe ImJeremyHe restored the jh/dev-node branch July 9, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.