forked from OffchainLabs/nitro
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode transactions in RLP format #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
philippecamacho,
sveitser and
jbearer
as code owners
December 7, 2023 03:06
ImJeremyHe
force-pushed
the
jh/serialize
branch
from
December 7, 2023 04:26
8572856
to
3d5d2f1
Compare
When moving to RLP encoding using int8 as a workaround to avoid base64 no longer works. I'm not sure the way the encoding is done now is a good idea though, we may want to rethink it.
ImJeremyHe
commented
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep this PR unmerged until we get a version where everything works successfully.
This was referenced Dec 11, 2023
Merged
ImJeremyHe
force-pushed
the
jh/serialize
branch
from
December 18, 2023 04:14
1a9d39e
to
fc22d6d
Compare
ImJeremyHe
force-pushed
the
jh/serialize
branch
from
December 18, 2023 04:15
fc22d6d
to
9259bd5
Compare
sveitser
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zacshowa
pushed a commit
that referenced
this pull request
Nov 26, 2024
* forge install: automata-dcap-attestation v0.1.1 * Add automata attestation to Sequencer Inbox * Add automata verifier to the Sequencer Inbox * Update tests and contracts * add address to the end * make hardhat build work as well * make tests work * make tests work * attempt tests * add tests * add tests for EspressoTEEVerifier * add tests to SequencerInbox * revert 4844 chanegs * source .env * fix broken ci * fix test * Make espressoTEEVerifier non upgrdeable and use V3QuoteVerifier contract directly * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.