CI: build nitro docker image #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directory is emptied at the start and end of each run.
The github runner runs out of space.
sveitser
force-pushed
the
ma/nitro-docker
branch
from
87968a1 to
dab175f
Compare
- Remove some TODOs
The workflow_dispatch only seems to work after the PR is merged.
8 tasks
- Fix github if expressions. - Add trigger for release tag.
For this to work we first need a tagged release on github that exported the wasm machine as release artifact.
sveitser
requested review from
ImJeremyHe,
nomaxg,
philippecamacho and
jbearer
as code owners
|
There still something wrong with the docker outputs field. Will investigate. |
It's not quite clear how to configure the docker build step to do the right thing. With this change the docker image is not built on PR but can still be built via manual triggering if that's desired.
|
I removed the PR trigger for the docker build workflow. Once the PR is merged the workflow can still be manually triggered for testing. |
zacshowa
pushed a commit
that referenced
this pull request
Nov 26, 2024
arbwasm: add ProgramActivated event
zacshowa
pushed a commit
that referenced
this pull request
Nov 26, 2024
Add support for custom token fee - ERC20 based rollups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close EspressoSystems/espresso-sequencer#783