Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all "not found" errors #175

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Check all "not found" errors #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arbnode/dataposter/dbstorage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (s *Storage) Get(_ context.Context, index uint64) (*storage.QueuedTransacti
key := idxToKey(index)
value, err := s.db.Get(key)
if err != nil {
if errors.Is(err, leveldb.ErrNotFound) {
if isErrNotFound(err) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call - and are the only errors we care about catching the ones we care about in this function?

func isErrNotFound(err error) bool {
	return errors.Is(err, leveldb.ErrNotFound) || errors.Is(err, pebble.ErrNotFound) || errors.Is(err, memorydb.ErrMemorydbNotFound)
}

Copy link
Author

@sveitser sveitser Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know for sure but I believe the implementation of the function that was changed in this PR is supposed to hide the "not found" errors for all db backend implementations, and only these errors.

return nil, nil
}
return nil, err
Expand Down
Loading