-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove postgres in espresso e2e test #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! One question just for my own understanding - you mentioned that dev node doesnt require postgres but isnt it running a script here?
I would like to expand on Sneh's comment and check my own understanding of docker. It seems as if postgres was recently added into the launch script for the dev node. Further, the env variables used for configuration would have been coming from the .env and docker-compose file in this repo. From my current understanding, this would imply that the If this isn't the case, is postgres use being handled entirely within the espresso-sequencer repo now? Does omitting the postgres setup information mean that somewhere in the pipeline we decide to not start postgres gracefully? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment to further my understanding of the lifecycle of building the docker image related to these changes. Other than that LGTM 🚢
Currently @zacshowa I think you can get the answer from this script. This script will be copied to the image. The entry of |
Since this PR EspressoSystems/espresso-sequencer#1707 has been merged and the
espresso-dev-node
doesn't require us to run apostgres
anymore, so we can remove relevant config and make it cleaner.And we also added a dev-node port for debugging according to EspressoSystems/espresso-sequencer#1709