-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream 20240709 #143
Conversation
This message will be seen by external users, so we should avoid mentioning the data poster.
Initially, this package is able to prase the download URLs and wasm root hash from a consensus release.
Fix solgen paths with new foundry versions
…reater-tip Make sure fee > tip in validator wallet estimateGas
…ter_dangerous_config [NIT-2593] Tests for AllowPostingFirstBatchWhenSequencerMessageCountMismatch
The bulk of this change is wiring the Wasm.RootPath through to the right places to make sure that all of the machine locators are initialized with the same root.
…master ArbOS 31
…oad-manifest [NIT-2589] init: define parts with manifest file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just one clarifying question that shouldn't stop a merge.
|
||
// This is only for testing the switch sequencer. Will be removed if the espresso light client | ||
// contract is ready and we will use another way to trigger the mode switching. | ||
SetMode(ctx context.Context, espresso bool) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own clarification, the removal of this function does not imply the deprecation of SwitchToEspresso
and SwitchToCentralized
for the purposes of integration tests correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite clear what you meant. As you can see, the trigger to switch to another mode is our light client contract.
if s.lightClient != nil { |
Before the contract was done, we had finished the switching functionality and that was why we chose to add a manual trigger to test the
switch
.
Set proper params for SequencerInbox
This PR:
This PR does not:
add other features or fix other things