Add escape hatch test in e2e test #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomaxg
reviewed
Jul 1, 2024
system_tests/espresso_e2e_test.go
Outdated
| // Wait for the switch to be totally finished | ||
| currMsg, err := node.ConsensusNode.TxStreamer.GetMessageCount() | ||
| Require(t, err) | ||
| validatedMsg := arbutil.MessageIndex(0) |
There was a problem hiding this comment.
Why are we checking the first message here?
There was a problem hiding this comment.
Thanks. Just want to declare a variable here. Have changed to var validatedMsg arbutil.MessageIndex. This would be better
ImJeremyHe
requested review from
philippecamacho,
sveitser and
jbearer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Add the escape hatch test in the e2e test. Instead of triggering the switching mode by setting the mode in the
SwitchSequencer, this test will use the mock light client contract directly.This PR also fixes a bug that trigger doesn't get the hotshot liveness correctly.
This PR does not:
Do other logic
Relevant PRs:
EspressoSystems/espresso-sequencer#1650
EspressoSystems/espresso-sequencer-go#45