Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the staker test #132

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix the staker test #132

merged 2 commits into from
Jun 25, 2024

Conversation

ImJeremyHe
Copy link
Member

@ImJeremyHe ImJeremyHe commented Jun 18, 2024 •
edited
Loading

Close: #117

This PR:

  • Fix the batch poster where we pulled the wrong block_justification
  • Fix the WASM binary which didn't verify the block merkle proof when the txes is not found in the hotshot block
  • Fix the tests regarding the updates in the light client contract

Relevent PRs:

How to test this PR:

Run this command locally since we don't check the staker test in the CI:

E2E_CHECK_STAKER=1 go test -v -count=1 -timeout 25m -run ^TestEspressoE2E$ github.com/offchainlabs/nitro/system_tests

There is a probablity that this test can not pass because of unknown issues for me and I guess it is because of limited resources in my computer.

@ImJeremyHe ImJeremyHe force-pushed the jh/fraud branch 3 times, most recently from bdf086f to 2afd1cf Compare June 24, 2024 03:12
@ImJeremyHe ImJeremyHe changed the title Jh/fraud Fix the staker test Jun 24, 2024
@ImJeremyHe ImJeremyHe marked this pull request as ready for review June 24, 2024 14:05
nomaxg
nomaxg approved these changes Jun 24, 2024
View reviewed changes
Copy link

@nomaxg nomaxg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ImJeremyHe ImJeremyHe merged commit 75b47fd into integration Jun 25, 2024
6 of 7 checks passed
@ImJeremyHe ImJeremyHe deleted the jh/fraud branch June 25, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomaxg nomaxg nomaxg approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix fraud proofs
2 participants
@ImJeremyHe @nomaxg