forked from OffchainLabs/nitro
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Client States Updates #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomaxg
requested review from
ImJeremyHe,
philippecamacho,
sveitser and
jbearer
as code owners
April 2, 2024 15:20
ImJeremyHe
pushed a commit
that referenced
this pull request
May 8, 2024
Update stylus header to 0xEFF000
ImJeremyHe
force-pushed
the
mock-validation
branch
2 times, most recently
from
May 8, 2024 06:48
bea541c
to
e965ef0
Compare
ImJeremyHe
force-pushed
the
mock-validation
branch
from
May 8, 2024 07:02
e965ef0
to
a7d9d43
Compare
This allows the sequencer to make progress past block 1. These env vars have been changed in espresso-sequencer.
This reverts commit 8be940c.
tbro
reviewed
May 8, 2024
ImJeremyHe
force-pushed
the
mock-validation
branch
from
May 9, 2024 06:57
c901c01
to
10d3214
Compare
ImJeremyHe
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR can be merged now. We can fix or do other things in next PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This PR introduces light client state updates to our Arbitrum integration, as well as recent miscellaneous changes to get our E2E test working with Cappuccino-related sequencer updates.
At a high level, the batcher now waits for light client state updates, updating batches with a block merkle justification relative to a light client snapshot at a certain L1 height. The validator then verifies this merkle proof against the snapshot, which is provided by the
ReadHotShotCommitment
host-io call.This PR does not:
In the process of working on this PR, two issues have been identified.
Key places to review:
batch_poster.go:465: Modification to the batcher to wait for light client state updates
transaction_streamer.go:664: Small DB workaround to account for the fact that batches can now change in flight.
espresso-crypto-helper/src/lib.rs:47: Helper function to verify merkle proofs.
How to test this PR: