Copy addresses before deleting struct

EspressoSystems · Feb 23, 2022 · ef20c7b · ef20c7b
1 parent 57e0332
commit ef20c7b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/solgen/src/challenge/ChallengeManager.sol b/solgen/src/challenge/ChallengeManager.sol
@@ -310,11 +310,13 @@ contract ChallengeManager is DelegateCallAware, IChallengeManager {
     /// @dev This function causes the mode of the challenge to be set to NONE by deleting the challenge
     function _nextWin(uint64 challengeIndex, ChallengeTerminationType reason) private {
         ChallengeLib.Challenge storage challenge = challenges[challengeIndex];
+        address next = challenge.next.addr;
+        address current = challenge.current.addr;
         delete challenges[challengeIndex];
         resultReceiver.completeChallenge(
             challengeIndex,
-            challenge.next.addr,
-            challenge.current.addr
+            next,
+            current
         );
         emit ChallengeEnded(challengeIndex, reason);
     }
@@ -331,6 +333,8 @@ contract ChallengeManager is DelegateCallAware, IChallengeManager {
         ChallengeLib.Challenge storage challenge = challenges[challengeIndex];
         challenge.challengeStateHash = bytes32(0);
 
+        //        address next = challenge.next.addr;
+        //        address current = challenge.current.addr;
         //        delete challenges[challengeIndex];
         //        resultReceiver.completeChallenge(challengeIndex, challenge.current.addr, challenge.next.addr);
         //        emit ChallengeEnded(challengeIndex, reason);