Skip to content

Commit

Permalink
push minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Sneh1999 committed Dec 17, 2024
1 parent 139ac64 commit a2c56f9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
12 changes: 5 additions & 7 deletions arbnode/batch_poster.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ type BatchPosterConfig struct {
UseEscapeHatch bool `koanf:"use-escape-hatch"`
EspressoTxnsPollingInterval time.Duration `koanf:"espresso-txns-polling-interval"`
EspressoSwitchDelayThreshold uint64 `koanf:"espresso-switch-delay-threshold"`
EspressoMaxTransactioSize uint64 `koanf:"espresso-max-transaction-size"`
EspressoMaxTransactionSize uint64 `koanf:"espresso-max-transaction-size"`
}

func (c *BatchPosterConfig) Validate() error {
Expand Down Expand Up @@ -245,7 +245,7 @@ func BatchPosterConfigAddOptions(prefix string, f *pflag.FlagSet) {
redislock.AddConfigOptions(prefix+".redis-lock", f)
dataposter.DataPosterConfigAddOptions(prefix+".data-poster", f, dataposter.DefaultDataPosterConfig)
genericconf.WalletConfigAddOptions(prefix+".parent-chain-wallet", f, DefaultBatchPosterConfig.ParentChainWallet.Pathname)
f.Uint64(prefix+".espresso-max-transaction-size", DefaultBatchPosterConfig.EspressoSwitchDelayThreshold, "specifies the max size of a espresso transasction")
f.Uint64(prefix+".espresso-max-transaction-size", DefaultBatchPosterConfig.EspressoMaxTransactionSize, "specifies the max size of a espresso transasction")
}

var DefaultBatchPosterConfig = BatchPosterConfig{
Expand Down Expand Up @@ -279,7 +279,7 @@ var DefaultBatchPosterConfig = BatchPosterConfig{
EspressoSwitchDelayThreshold: 350,
LightClientAddress: "",
HotShotUrl: "",
EspressoMaxTransactioSize: 900 * 1024,
EspressoMaxTransactionSize: 900 * 1024,
}

var DefaultBatchPosterL1WalletConfig = genericconf.WalletConfig{
Expand Down Expand Up @@ -316,7 +316,7 @@ var TestBatchPosterConfig = BatchPosterConfig{
EspressoSwitchDelayThreshold: 10,
LightClientAddress: "",
HotShotUrl: "",
EspressoMaxTransactioSize: 25 * 1024,
EspressoMaxTransactionSize: 900 * 1024,
}

type BatchPosterOpts struct {
Expand Down Expand Up @@ -381,7 +381,7 @@ func NewBatchPoster(ctx context.Context, opts *BatchPosterOpts) (*BatchPoster, e
opts.Streamer.UseEscapeHatch = opts.Config().UseEscapeHatch
opts.Streamer.espressoTxnsPollingInterval = opts.Config().EspressoTxnsPollingInterval
opts.Streamer.espressoSwitchDelayThreshold = opts.Config().EspressoSwitchDelayThreshold
opts.Streamer.espressoMaxTransactionSize = opts.Config().EspressoMaxTransactioSize
opts.Streamer.espressoMaxTransactionSize = opts.Config().EspressoMaxTransactionSize
}

b := &BatchPoster{
Expand Down Expand Up @@ -1128,8 +1128,6 @@ func (b *BatchPoster) encodeAddBatch(
return nil, nil, fmt.Errorf("failed to get attestation quote: %w", err)
}

log.Info("Attestation Quote", "quote", hex.EncodeToString(attestationQuote))

// construct the calldata with attestation quote
method, ok = b.seqInboxABI.Methods[newSequencerBatchPostMethodName]
if !ok {
Expand Down
2 changes: 1 addition & 1 deletion arbnode/transaction_streamer.go
Original file line number Diff line number Diff line change
Expand Up @@ -1842,7 +1842,7 @@ func (s *TransactionStreamer) espressoSwitch(ctx context.Context, ignored struct
return 0
}
logLevel := getLogLevel(err)
logLevel("error polling finality", "err", err)
logLevel("error polling finality, will retry", "err", err)
return retryRate
} else {
espressoMerkleProofEphemeralErrorHandler.Reset()
Expand Down

0 comments on commit a2c56f9

Please sign in to comment.