Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix range-gate #64

Merged
merged 1 commit into from
May 12, 2022
Merged

bugfix range-gate #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions plonk/src/circuit/customized/ultraplonk/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ impl<F: PrimeField> PlonkCircuit<F> {
}

// add linear combination gates
if len > 1 {
self.decompose_vars_gate(reprs_le_vars, a, F::from(range_size as u64))?;
}
self.decompose_vars_gate(reprs_le_vars, a, F::from(range_size as u64))?;

Ok(())
}
Expand Down Expand Up @@ -155,6 +153,16 @@ mod test {
*circuit.witness_mut(a[0]) = tmp;

let mut circuit: PlonkCircuit<F> = PlonkCircuit::new_ultra_plonk(RANGE_BIT_LEN_FOR_TEST);
// Should fail when the value = 2^RANGE_BIT_LEN_FOR_TEST
let a_var = circuit.create_variable(F::from(1u32 << RANGE_BIT_LEN_FOR_TEST))?;
circuit.range_gate_with_lookup(a_var, RANGE_BIT_LEN_FOR_TEST)?;
assert!(circuit.check_circuit_satisfiability(&[]).is_err());

// Should fail when the value = 2^{2*RANGE_BIT_LEN_FOR_TEST}
let a_var = circuit.create_variable(F::from(1u32 << (2 * RANGE_BIT_LEN_FOR_TEST)))?;
circuit.range_gate_with_lookup(a_var, 2 * RANGE_BIT_LEN_FOR_TEST)?;
assert!(circuit.check_circuit_satisfiability(&[]).is_err());

let zero_var = circuit.zero();
// bit_len = 0
assert!(circuit.range_gate_with_lookup(zero_var, 0).is_err());
Expand Down